You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2020/04/04 10:01:19 UTC
[GitHub] [incubator-iotdb] vesense opened a new pull request #986: [IOTDB-578] Cluster module should use the same thrift version with io…
vesense opened a new pull request #986: [IOTDB-578] Cluster module should use the same thrift version with io…
URL: https://github.com/apache/incubator-iotdb/pull/986
…tdb-parent
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-iotdb] jixuan1989 commented on a change in pull request #986: [IOTDB-578] Cluster module should use the same thrift version with io…
Posted by GitBox <gi...@apache.org>.
jixuan1989 commented on a change in pull request #986: [IOTDB-578] Cluster module should use the same thrift version with io…
URL: https://github.com/apache/incubator-iotdb/pull/986#discussion_r403468907
##########
File path: cluster/pom.xml
##########
@@ -34,11 +34,6 @@
<cluster.ut.skip>${cluster.test.skip}</cluster.ut.skip>
</properties>
<dependencies>
- <dependency>
- <groupId>org.apache.thrift</groupId>
- <artifactId>libthrift</artifactId>
Review comment:
I think we can only remove the version here.
In the parent pom, the libthrift is claimed in dependencyManagement, rather than dependencies.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-iotdb] vesense commented on a change in pull request #986: [IOTDB-578] Cluster module should use the same thrift version with io…
Posted by GitBox <gi...@apache.org>.
vesense commented on a change in pull request #986: [IOTDB-578] Cluster module should use the same thrift version with io…
URL: https://github.com/apache/incubator-iotdb/pull/986#discussion_r403585288
##########
File path: cluster/pom.xml
##########
@@ -34,11 +34,6 @@
<cluster.ut.skip>${cluster.test.skip}</cluster.ut.skip>
</properties>
<dependencies>
- <dependency>
- <groupId>org.apache.thrift</groupId>
- <artifactId>libthrift</artifactId>
Review comment:
@jixuan1989 the `cluster` module is dependent on `service-rpc`, and `service-rpc` module has the `libthrift` dependency which version extends from parent. So we don't need to add the `libthrift` dependency to cluster module separately.
```
service-rpc/pom.xml
<dependency>
<groupId>org.apache.thrift</groupId>
<artifactId>libthrift</artifactId>
</dependency>
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-iotdb] jixuan1989 merged pull request #986: [IOTDB-578] Cluster module should use the same thrift version with io…
Posted by GitBox <gi...@apache.org>.
jixuan1989 merged pull request #986: [IOTDB-578] Cluster module should use the same thrift version with io…
URL: https://github.com/apache/incubator-iotdb/pull/986
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-iotdb] jt2594838 commented on issue #986: [IOTDB-578] Cluster module should use the same thrift version with io…
Posted by GitBox <gi...@apache.org>.
jt2594838 commented on issue #986: [IOTDB-578] Cluster module should use the same thrift version with io…
URL: https://github.com/apache/incubator-iotdb/pull/986#issuecomment-610943497
thrift 0.13.0 used by the stand-alone IoTDB will cause bugs in Mac OS and that is why we use a separate version in the distributed version.
PLEASE, do not merge any outside code without informing the committers who are working on this branch.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services