You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/09/02 15:41:03 UTC

[GitHub] [incubator-superset] craig-rueda opened a new pull request #10766: fix: re-installing local superset in cache image

craig-rueda opened a new pull request #10766:
URL: https://github.com/apache/incubator-superset/pull/10766


   ### SUMMARY
   Fixes issue with differing dependency versions in cache image vs requirements found in local install. Basically, the local `superset` package will always be re-installed on top of the cache image's superset in order to ensure that the deps align.
   
   Fixes #10765
   
   @hyunjong-lee - FYI


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #10766: fix: re-installing local superset in cache image

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #10766:
URL: https://github.com/apache/incubator-superset/pull/10766#issuecomment-685930415


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10766?src=pr&el=h1) Report
   > Merging [#10766](https://codecov.io/gh/apache/incubator-superset/pull/10766?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/8c564fba3886b184ab8da983c49386c9000afa3f?el=desc) will **increase** coverage by `6.42%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/10766/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/10766?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #10766      +/-   ##
   ==========================================
   + Coverage   58.89%   65.31%   +6.42%     
   ==========================================
     Files         762      801      +39     
     Lines       36292    37723    +1431     
     Branches     3301     3548     +247     
   ==========================================
   + Hits        21375    24640    +3265     
   + Misses      14734    12977    -1757     
   + Partials      183      106      -77     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `56.21% <ø> (-0.01%)` | :arrow_down: |
   | #javascript | `61.47% <ø> (?)` | |
   | #python | `60.84% <ø> (+0.48%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10766?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset-frontend/src/setup/setupPlugins.ts](https://codecov.io/gh/apache/incubator-superset/pull/10766/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwUGx1Z2lucy50cw==) | `22.22% <0.00%> (-77.78%)` | :arrow_down: |
   | [superset-frontend/src/views/index.tsx](https://codecov.io/gh/apache/incubator-superset/pull/10766/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL2luZGV4LnRzeA==) | `25.00% <0.00%> (-75.00%)` | :arrow_down: |
   | [superset-frontend/src/SqlLab/index.tsx](https://codecov.io/gh/apache/incubator-superset/pull/10766/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9pbmRleC50c3g=) | `25.00% <0.00%> (-75.00%)` | :arrow_down: |
   | [superset-frontend/src/views/App.tsx](https://codecov.io/gh/apache/incubator-superset/pull/10766/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0FwcC50c3g=) | `32.35% <0.00%> (-67.65%)` | :arrow_down: |
   | [...rset-frontend/src/setup/setupErrorMessagesExtra.ts](https://codecov.io/gh/apache/incubator-superset/pull/10766/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwRXJyb3JNZXNzYWdlc0V4dHJhLnRz) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
   | [superset-frontend/src/setup/setupErrorMessages.ts](https://codecov.io/gh/apache/incubator-superset/pull/10766/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwRXJyb3JNZXNzYWdlcy50cw==) | `54.54% <0.00%> (-45.46%)` | :arrow_down: |
   | [superset-frontend/src/views/menu.tsx](https://codecov.io/gh/apache/incubator-superset/pull/10766/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL21lbnUudHN4) | `60.00% <0.00%> (-40.00%)` | :arrow_down: |
   | [superset-frontend/src/preamble.ts](https://codecov.io/gh/apache/incubator-superset/pull/10766/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ByZWFtYmxlLnRz) | `56.52% <0.00%> (-24.73%)` | :arrow_down: |
   | [superset-frontend/src/components/FlashProvider.tsx](https://codecov.io/gh/apache/incubator-superset/pull/10766/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRmxhc2hQcm92aWRlci50c3g=) | `42.85% <0.00%> (-17.15%)` | :arrow_down: |
   | [...s/ErrorMessage/getErrorMessageComponentRegistry.ts](https://codecov.io/gh/apache/incubator-superset/pull/10766/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL2dldEVycm9yTWVzc2FnZUNvbXBvbmVudFJlZ2lzdHJ5LnRz) | `85.71% <0.00%> (-14.29%)` | :arrow_down: |
   | ... and [262 more](https://codecov.io/gh/apache/incubator-superset/pull/10766/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10766?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10766?src=pr&el=footer). Last update [8c564fb...c847d6d](https://codecov.io/gh/apache/incubator-superset/pull/10766?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] Zverik commented on pull request #10766: fix: re-installing local superset in cache image

Posted by GitBox <gi...@apache.org>.
Zverik commented on pull request #10766:
URL: https://github.com/apache/incubator-superset/pull/10766#issuecomment-687097568


   Worked for me.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] craig-rueda merged pull request #10766: fix: re-installing local superset in cache image

Posted by GitBox <gi...@apache.org>.
craig-rueda merged pull request #10766:
URL: https://github.com/apache/incubator-superset/pull/10766


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] willbarrett commented on pull request #10766: fix: re-installing local superset in cache image

Posted by GitBox <gi...@apache.org>.
willbarrett commented on pull request #10766:
URL: https://github.com/apache/incubator-superset/pull/10766#issuecomment-685839782


   I hope this works! Cached dependencies have been a big pain recently. Thanks!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-commenter commented on pull request #10766: fix: re-installing local superset in cache image

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #10766:
URL: https://github.com/apache/incubator-superset/pull/10766#issuecomment-685930415


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10766?src=pr&el=h1) Report
   > Merging [#10766](https://codecov.io/gh/apache/incubator-superset/pull/10766?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/8c564fba3886b184ab8da983c49386c9000afa3f?el=desc) will **increase** coverage by `6.32%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/10766/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/10766?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #10766      +/-   ##
   ==========================================
   + Coverage   58.89%   65.21%   +6.32%     
   ==========================================
     Files         762      801      +39     
     Lines       36292    37723    +1431     
     Branches     3301     3548     +247     
   ==========================================
   + Hits        21375    24602    +3227     
   + Misses      14734    13012    -1722     
   + Partials      183      109      -74     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `55.70% <ø> (-0.52%)` | :arrow_down: |
   | #javascript | `61.47% <ø> (?)` | |
   | #python | `60.84% <ø> (+0.48%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10766?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset-frontend/src/setup/setupPlugins.ts](https://codecov.io/gh/apache/incubator-superset/pull/10766/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwUGx1Z2lucy50cw==) | `22.22% <0.00%> (-77.78%)` | :arrow_down: |
   | [superset-frontend/src/views/index.tsx](https://codecov.io/gh/apache/incubator-superset/pull/10766/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL2luZGV4LnRzeA==) | `25.00% <0.00%> (-75.00%)` | :arrow_down: |
   | [superset-frontend/src/SqlLab/index.tsx](https://codecov.io/gh/apache/incubator-superset/pull/10766/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9pbmRleC50c3g=) | `25.00% <0.00%> (-75.00%)` | :arrow_down: |
   | [superset-frontend/src/views/App.tsx](https://codecov.io/gh/apache/incubator-superset/pull/10766/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0FwcC50c3g=) | `32.35% <0.00%> (-67.65%)` | :arrow_down: |
   | [...rset-frontend/src/setup/setupErrorMessagesExtra.ts](https://codecov.io/gh/apache/incubator-superset/pull/10766/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwRXJyb3JNZXNzYWdlc0V4dHJhLnRz) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
   | [superset-frontend/src/setup/setupErrorMessages.ts](https://codecov.io/gh/apache/incubator-superset/pull/10766/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwRXJyb3JNZXNzYWdlcy50cw==) | `54.54% <0.00%> (-45.46%)` | :arrow_down: |
   | [superset-frontend/src/views/menu.tsx](https://codecov.io/gh/apache/incubator-superset/pull/10766/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL21lbnUudHN4) | `60.00% <0.00%> (-40.00%)` | :arrow_down: |
   | [superset-frontend/src/preamble.ts](https://codecov.io/gh/apache/incubator-superset/pull/10766/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ByZWFtYmxlLnRz) | `56.52% <0.00%> (-24.73%)` | :arrow_down: |
   | [superset-frontend/src/components/FlashProvider.tsx](https://codecov.io/gh/apache/incubator-superset/pull/10766/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRmxhc2hQcm92aWRlci50c3g=) | `42.85% <0.00%> (-17.15%)` | :arrow_down: |
   | [...et-frontend/src/SqlLab/reducers/getInitialState.js](https://codecov.io/gh/apache/incubator-superset/pull/10766/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9yZWR1Y2Vycy9nZXRJbml0aWFsU3RhdGUuanM=) | `33.33% <0.00%> (-16.67%)` | :arrow_down: |
   | ... and [264 more](https://codecov.io/gh/apache/incubator-superset/pull/10766/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10766?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10766?src=pr&el=footer). Last update [8c564fb...c847d6d](https://codecov.io/gh/apache/incubator-superset/pull/10766?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org