You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/01/25 09:27:30 UTC

[GitHub] [cloudstack] Pearl1594 commented on a change in pull request #4615: Secondary storage: Allow store deletion after successful data migration

Pearl1594 commented on a change in pull request #4615:
URL: https://github.com/apache/cloudstack/pull/4615#discussion_r563572941



##########
File path: server/src/main/java/com/cloud/api/query/dao/TemplateJoinDaoImpl.java
##########
@@ -522,6 +522,7 @@ public TemplateResponse newIsoResponse(TemplateJoinVO iso) {
         sc.setParameters("store_id", storeId);
         sc.setParameters("type", TemplateType.USER);
         sc.setParameters("templateState", VirtualMachineTemplate.State.Active);
+        sc.setParameters("public", Boolean.FALSE);

Review comment:
       @shwstppr Deletion of image stores will be prevented only if there are private user templates present on the respective store.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org