You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@bloodhound.apache.org by rj...@apache.org on 2013/07/13 09:06:35 UTC
svn commit: r1502757 - /bloodhound/trunk/bloodhound_relations/setup.py
Author: rjollos
Date: Sat Jul 13 07:06:34 2013
New Revision: 1502757
URL: http://svn.apache.org/r1502757
Log:
Package `bhrelations.widgets` was not specified in `setup.py`. Fixes #582.
The `TicketRelationsWidget` component was being displayed separate from the `BloodhoundRelationsPlugin` package because it was not being included in the egg and was being discovered as a single file plugin by `trac.loader.get_plugin_info`.
Modified:
bloodhound/trunk/bloodhound_relations/setup.py
Modified: bloodhound/trunk/bloodhound_relations/setup.py
URL: http://svn.apache.org/viewvc/bloodhound/trunk/bloodhound_relations/setup.py?rev=1502757&r1=1502756&r2=1502757&view=diff
==============================================================================
--- bloodhound/trunk/bloodhound_relations/setup.py (original)
+++ bloodhound/trunk/bloodhound_relations/setup.py Sat Jul 13 07:06:34 2013
@@ -98,6 +98,8 @@ PKG_INFO = {'bhrelations': ('bhrelations
'htdocs/img/*.*', 'htdocs/js/*.js',
'templates/*', 'default-pages/*'],
),
+ 'bhrelations.widgets': (
+ 'bhrelations/widgets', ['templates/*.html']),
'bhrelations.tests': (
'bhrelations/tests', ['data/*.*']),
}
Re: svn commit: r1502757 - /bloodhound/trunk/bloodhound_relations/setup.py
Posted by Ryan Ollos <ry...@wandisco.com>.
On Sat, Jul 13, 2013 at 12:06 AM, <rj...@apache.org> wrote:
> Author: rjollos
> Date: Sat Jul 13 07:06:34 2013
> New Revision: 1502757
>
> URL: http://svn.apache.org/r1502757
> Log:
> Package `bhrelations.widgets` was not specified in `setup.py`. Fixes #582.
>
> The `TicketRelationsWidget` component was being displayed separate from
> the `BloodhoundRelationsPlugin` package because it was not being included
> in the egg and was being discovered as a single file plugin by
> `trac.loader.get_plugin_info`.
>
> Modified:
> bloodhound/trunk/bloodhound_relations/setup.py
>
> Modified: bloodhound/trunk/bloodhound_relations/setup.py
> URL:
> http://svn.apache.org/viewvc/bloodhound/trunk/bloodhound_relations/setup.py?rev=1502757&r1=1502756&r2=1502757&view=diff
>
> ==============================================================================
> --- bloodhound/trunk/bloodhound_relations/setup.py (original)
> +++ bloodhound/trunk/bloodhound_relations/setup.py Sat Jul 13 07:06:34 2013
> @@ -98,6 +98,8 @@ PKG_INFO = {'bhrelations': ('bhrelations
> 'htdocs/img/*.*', 'htdocs/js/*.js',
> 'templates/*', 'default-pages/*'],
> ),
> + 'bhrelations.widgets': (
> + 'bhrelations/widgets', ['templates/*.html']),
> 'bhrelations.tests': (
> 'bhrelations/tests', ['data/*.*']),
> }
>
Noticed while working on this issue, it looks like we can remove the
following from the `setup.py` files, because we don't even support Python <
2.6.
----
# Be compatible with older versions of Python
from sys import version
if version < '2.2.3':
from distutils.dist import DistributionMetadata
DistributionMetadata.classifiers = None
DistributionMetadata.download_url = None
----
The documentation agrees with the comment in the source,
http://docs.python.org/2/distutils/setupscript.html#additional-meta-data
Any objections?