[GitHub] [spark] HyukjinKwon commented on a change in pull request #28554: [SPARK-31735][CORE] Include date/timestamp in the summary report

[GitBox <gi...@apache.org>]

HyukjinKwon commented on a change in pull request #28554:
URL: https://github.com/apache/spark/pull/28554#discussion_r426338058



##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/stat/StatFunctions.scala
##########
@@ -264,7 +264,10 @@ object StatFunctions extends Logging {
     }
 
     val selectedCols = ds.logicalPlan.output
-      .filter(a => a.dataType.isInstanceOf[NumericType] || a.dataType.isInstanceOf[StringType])
+      .filter(a => a.dataType.isInstanceOf[NumericType]
+        || a.dataType.isInstanceOf[StringType]
+        || a.dataType.isInstanceOf[DateType]

Review comment:
       Yes, let's write a UT. Does it work BTW? Looks at least `mean` and date type won't work here.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org