You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/07/20 15:54:41 UTC
[GitHub] [skywalking-python] kezhenxu94 opened a new pull request #46: Test: print the diff list when validation failed
kezhenxu94 opened a new pull request #46:
URL: https://github.com/apache/skywalking-python/pull/46
This patch makes it more convenient for the developers when running tests locally and the tests failed
<img width="1440" alt="image" src="https://user-images.githubusercontent.com/15965696/87958515-36dc8f80-cae4-11ea-8b4b-cb4ce07fcbe8.png">
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-python] kezhenxu94 edited a comment on pull request #46: Test: print the diff list when validation failed
Posted by GitBox <gi...@apache.org>.
kezhenxu94 edited a comment on pull request #46:
URL: https://github.com/apache/skywalking-python/pull/46#issuecomment-661126526
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-python] alonelaval commented on pull request #46: Test: print the diff list when validation failed
Posted by GitBox <gi...@apache.org>.
alonelaval commented on pull request #46:
URL: https://github.com/apache/skywalking-python/pull/46#issuecomment-661572144
> This patch makes it more convenient for the developers when running tests locally and the tests failed
>
>
>
> <img width="1440" alt="image" src="https://user-images.githubusercontent.com/15965696/87958515-36dc8f80-cae4-11ea-8b4b-cb4ce07fcbe8.png">
>
>
👌
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-python] kezhenxu94 merged pull request #46: Test: print the diff list when validation failed
Posted by GitBox <gi...@apache.org>.
kezhenxu94 merged pull request #46:
URL: https://github.com/apache/skywalking-python/pull/46
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-python] kezhenxu94 commented on pull request #46: Test: print the diff list when validation failed
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on pull request #46:
URL: https://github.com/apache/skywalking-python/pull/46#issuecomment-661126526
@alonelaval if you're interested in, feel free to review, I cannot request your review because you're not committer yet
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-python] wu-sheng commented on pull request #46: Test: print the diff list when validation failed
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #46:
URL: https://github.com/apache/skywalking-python/pull/46#issuecomment-661653066
Should I wait for @alonelaval feedback.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org