You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "walkinggo (via GitHub)" <gi...@apache.org> on 2024/12/23 06:17:19 UTC
[PR] suggest passing the token as headers [pulsar-site]
walkinggo opened a new pull request, #981:
URL: https://github.com/apache/pulsar-site/pull/981
### ✅ Contribution Checklist
<!--
Feel free to remove the checklist if it does not apply to your PR
-->
- [✅] I read the [contribution guide](https://pulsar.apache.org/contribute/document-contribution/)
- [✅] I updated the [versioned docs](https://pulsar.apache.org/contribute/document-contribution/#update-versioned-docs)
fix [issue23625](https://github.com/apache/pulsar/issues/23625),suggest passing the token as headers rather than query parameters.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Doc] Update websocket docs to suggest passing the token as headers rather than query parameters [pulsar-site]
Posted by "lhotari (via GitHub)" <gi...@apache.org>.
lhotari commented on PR #981:
URL: https://github.com/apache/pulsar-site/pull/981#issuecomment-3472143222
> @lhotari This looks like important advice.
Yes, but the update to versioned_docs/version-4.1.x is missing (since the release was made after this PR was created). The PR reviewer would need to handle such details. (related comment https://github.com/apache/pulsar-site/pull/982#issuecomment-3472134591)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Doc] Update websocket docs to suggest passing the token as headers rather than query parameters [pulsar-site]
Posted by "lhotari (via GitHub)" <gi...@apache.org>.
lhotari merged PR #981:
URL: https://github.com/apache/pulsar-site/pull/981
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Doc] Update websocket docs to suggest passing the token as headers rather than query parameters [pulsar-site]
Posted by "dave2wave (via GitHub)" <gi...@apache.org>.
dave2wave commented on PR #981:
URL: https://github.com/apache/pulsar-site/pull/981#issuecomment-3469047873
@lhotari This looks like important advice.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org