[GitHub] HyukjinKwon commented on issue #23307: [SPARK-26335][SQL] Add a property for Dataset#show not to care about wide characters when padding them

[GitBox <gi...@apache.org>]

HyukjinKwon commented on issue #23307: [SPARK-26335][SQL] Add a property for Dataset#show not to care about wide characters when padding them
URL: https://github.com/apache/spark/pull/23307#issuecomment-446890583
 
 
   I think it makes more sense that OASIS side implements one method, for instance, `showAsTable`
   
   ```scala
   implicit class OASIS(df: DataFrame) {
     def showAsTable(): DataFrame = {
       // Mimic `Dataset.showString`
     }
   }
   ```
   
   and
   
   ```scala
   dataset.showAsTable
   ```
   
   I think `df.show()` does not have a guarantee about how it's printed in console, and the purpose of this API is just to show a pretty string rather than parsing and using it. This configuration looks too specific to OASIS.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org