You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/12/18 18:25:56 UTC
[GitHub] [airflow] subkanthi opened a new pull request #20399: Fix mypy errors in airflow/kubernetes
subkanthi opened a new pull request #20399:
URL: https://github.com/apache/airflow/pull/20399
Fixes the following mypy errors in airflow/kubernetes
`mypy --namespace-packages airflow/kubernetes
airflow/kubernetes/pod_generator.py:459: error: Incompatible return value type (got "None", expected "str")
return None
^
airflow/kubernetes/kubernetes_helper_functions.py:76: error: Name "run_id" already defined on line 65
run_id: str = (
^
airflow/kubernetes/kubernetes_helper_functions.py:87: error: Argument 3 to "TaskInstanceKey" has incompatible type "Optional[str]"; expected "str"
return TaskInstanceKey(dag_id, task_id, run_id, try_number)
^
airflow/kubernetes/pod_launcher_deprecated.py:31: error: Module "requests.exceptions" has no attribute "BaseHTTPError"; maybe "HTTPError"?
from requests.exceptions import BaseHTTPError`
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #20399: Fix mypy errors in airflow/kubernetes
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #20399:
URL: https://github.com/apache/airflow/pull/20399
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org