You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Sahil Takiar (Code Review)" <ge...@cloudera.org> on 2019/08/16 18:33:13 UTC

[Impala-ASF-CR] IMPALA-8871: Upgrade Thrift version in fe

Sahil Takiar has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14084


Change subject: IMPALA-8871: Upgrade Thrift version in fe
......................................................................

IMPALA-8871: Upgrade Thrift version in fe

Upgrade fe/ Thrift version to 0.9.3-1.

Testing:
* Ran exhaustive tests.
* Ran perf-AB-test, which showed no significant perf difference.

Change-Id: If62e6330f0a725ebd4213c200656fc12a0eccf06
---
M impala-parent/pom.xml
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/84/14084/1
-- 
To view, visit http://gerrit.cloudera.org:8080/14084
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: If62e6330f0a725ebd4213c200656fc12a0eccf06
Gerrit-Change-Number: 14084
Gerrit-PatchSet: 1
Gerrit-Owner: Sahil Takiar <st...@cloudera.com>

[Impala-ASF-CR] IMPALA-8871: Upgrade Thrift version in fe

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14084 )

Change subject: IMPALA-8871: Upgrade Thrift version in fe
......................................................................


Patch Set 1:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4811/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/14084
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If62e6330f0a725ebd4213c200656fc12a0eccf06
Gerrit-Change-Number: 14084
Gerrit-PatchSet: 1
Gerrit-Owner: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 16 Aug 2019 20:47:05 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8871: Upgrade Thrift version in fe

Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14084 )

Change subject: IMPALA-8871: Upgrade Thrift version in fe
......................................................................


Patch Set 1: Code-Review+2

Thanks for doing this


-- 
To view, visit http://gerrit.cloudera.org:8080/14084
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If62e6330f0a725ebd4213c200656fc12a0eccf06
Gerrit-Change-Number: 14084
Gerrit-PatchSet: 1
Gerrit-Owner: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 16 Aug 2019 18:39:35 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8871: Upgrade Thrift version in fe

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14084 )

Change subject: IMPALA-8871: Upgrade Thrift version in fe
......................................................................


Patch Set 1: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/14084
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If62e6330f0a725ebd4213c200656fc12a0eccf06
Gerrit-Change-Number: 14084
Gerrit-PatchSet: 1
Gerrit-Owner: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Sat, 17 Aug 2019 00:57:30 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8871: Upgrade Thrift version in fe

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14084 )

Change subject: IMPALA-8871: Upgrade Thrift version in fe
......................................................................


Patch Set 1:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/4289/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/14084
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If62e6330f0a725ebd4213c200656fc12a0eccf06
Gerrit-Change-Number: 14084
Gerrit-PatchSet: 1
Gerrit-Owner: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 16 Aug 2019 20:35:55 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8871: Upgrade Thrift version in fe

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14084 )

Change subject: IMPALA-8871: Upgrade Thrift version in fe
......................................................................

IMPALA-8871: Upgrade Thrift version in fe

Upgrade fe/ Thrift version to 0.9.3-1.

Testing:
* Ran exhaustive tests.
* Ran perf-AB-test, which showed no significant perf difference.

Change-Id: If62e6330f0a725ebd4213c200656fc12a0eccf06
Reviewed-on: http://gerrit.cloudera.org:8080/14084
Reviewed-by: Tim Armstrong <ta...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M impala-parent/pom.xml
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Tim Armstrong: Looks good to me, approved
  Impala Public Jenkins: Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/14084
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: If62e6330f0a725ebd4213c200656fc12a0eccf06
Gerrit-Change-Number: 14084
Gerrit-PatchSet: 2
Gerrit-Owner: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>