You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by on 2019/02/22 02:45:14 UTC
Review Request 70041: ATLAS-3056: updated rdbms types to remove use of
ownedRef/inverseRef
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70041/
-----------------------------------------------------------
Review request for atlas, Ashutosh Mestry, keval bhatt, Nikhil Bonte, Nixon Rodrigues, and Sarath Subramanian.
Bugs: ATLAS-3056
https://issues.apache.org/jira/browse/ATLAS-3056
Repository: atlas
Description
-------
- updated RDBMS model to remove attributes that use ownedRef/inverseRef constraints
- updated corresponding relationship-types as COMPOSITION
- updated notification processing to fix notifications of earlier model for the model changes
Diffs
-----
addons/models/2000-RDBMS/2010-rdbms_model.json 386446c8c
webapp/src/main/java/org/apache/atlas/notification/NotificationHookConsumer.java 6d03ba492
webapp/src/main/java/org/apache/atlas/notification/preprocessor/EntityPreprocessor.java bdea14adf
webapp/src/main/java/org/apache/atlas/notification/preprocessor/RdbmsPreprocessor.java PRE-CREATION
Diff: https://reviews.apache.org/r/70041/diff/1/
Testing
-------
Pre-commit tests run: https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/932/
Thanks,
madhan
Re: Review Request 70041: ATLAS-3056: updated rdbms types to remove
use of ownedRef/inverseRef
Posted by Sarath Subramanian <sa...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70041/#review213087
-----------------------------------------------------------
Fix it, then Ship it!
Ship It!
webapp/src/main/java/org/apache/atlas/notification/preprocessor/EntityPreprocessor.java
Lines 71 (patched)
<https://reviews.apache.org/r/70041/#comment298957>
duplicate registration of preprocessor - HivePreprocessor.HiveStorageDescPreprocessor() line 71 and 72
webapp/src/main/java/org/apache/atlas/notification/preprocessor/RdbmsPreprocessor.java
Lines 121 (patched)
<https://reviews.apache.org/r/70041/#comment298956>
clearRefAtrributes => clearRefAttributes
- Sarath Subramanian
On Feb. 21, 2019, 7:28 p.m., madhan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70041/
> -----------------------------------------------------------
>
> (Updated Feb. 21, 2019, 7:28 p.m.)
>
>
> Review request for atlas, Ashutosh Mestry, keval bhatt, Nikhil Bonte, Nixon Rodrigues, and Sarath Subramanian.
>
>
> Bugs: ATLAS-3056
> https://issues.apache.org/jira/browse/ATLAS-3056
>
>
> Repository: atlas
>
>
> Description
> -------
>
> - updated RDBMS model to remove attributes that use ownedRef/inverseRef constraints
> - updated corresponding relationship-types as COMPOSITION
> - updated notification processing to fix notifications of earlier model for the model changes
>
>
> Diffs
> -----
>
> addons/models/2000-RDBMS/2010-rdbms_model.json 386446c8c
> webapp/src/main/java/org/apache/atlas/notification/NotificationHookConsumer.java 6d03ba492
> webapp/src/main/java/org/apache/atlas/notification/preprocessor/EntityPreprocessor.java bdea14adf
> webapp/src/main/java/org/apache/atlas/notification/preprocessor/RdbmsPreprocessor.java PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/70041/diff/2/
>
>
> Testing
> -------
>
> Pre-commit tests run: https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/932/
>
>
> Thanks,
>
> madhan
>
>
Re: Review Request 70041: ATLAS-3056: updated rdbms types to remove
use of ownedRef/inverseRef
Posted by Sarath Subramanian <sa...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70041/#review213089
-----------------------------------------------------------
Ship it!
Ship It!
- Sarath Subramanian
On Feb. 22, 2019, 10:48 a.m., madhan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70041/
> -----------------------------------------------------------
>
> (Updated Feb. 22, 2019, 10:48 a.m.)
>
>
> Review request for atlas, Ashutosh Mestry, keval bhatt, Nikhil Bonte, Nixon Rodrigues, and Sarath Subramanian.
>
>
> Bugs: ATLAS-3056
> https://issues.apache.org/jira/browse/ATLAS-3056
>
>
> Repository: atlas
>
>
> Description
> -------
>
> - updated RDBMS model to remove attributes that use ownedRef/inverseRef constraints
> - updated corresponding relationship-types as COMPOSITION
> - updated notification processing to fix notifications of earlier model for the model changes
>
>
> Diffs
> -----
>
> addons/models/2000-RDBMS/2010-rdbms_model.json 386446c8c
> webapp/src/main/java/org/apache/atlas/notification/NotificationHookConsumer.java 6d03ba492
> webapp/src/main/java/org/apache/atlas/notification/preprocessor/EntityPreprocessor.java bdea14adf
> webapp/src/main/java/org/apache/atlas/notification/preprocessor/RdbmsPreprocessor.java PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/70041/diff/4/
>
>
> Testing
> -------
>
> Pre-commit tests run: https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/932/
>
>
> Thanks,
>
> madhan
>
>
Re: Review Request 70041: ATLAS-3056: updated rdbms types to remove
use of ownedRef/inverseRef
Posted by .
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70041/
-----------------------------------------------------------
(Updated Feb. 22, 2019, 6:48 p.m.)
Review request for atlas, Ashutosh Mestry, keval bhatt, Nikhil Bonte, Nixon Rodrigues, and Sarath Subramanian.
Bugs: ATLAS-3056
https://issues.apache.org/jira/browse/ATLAS-3056
Repository: atlas
Description
-------
- updated RDBMS model to remove attributes that use ownedRef/inverseRef constraints
- updated corresponding relationship-types as COMPOSITION
- updated notification processing to fix notifications of earlier model for the model changes
Diffs (updated)
-----
addons/models/2000-RDBMS/2010-rdbms_model.json 386446c8c
webapp/src/main/java/org/apache/atlas/notification/NotificationHookConsumer.java 6d03ba492
webapp/src/main/java/org/apache/atlas/notification/preprocessor/EntityPreprocessor.java bdea14adf
webapp/src/main/java/org/apache/atlas/notification/preprocessor/RdbmsPreprocessor.java PRE-CREATION
Diff: https://reviews.apache.org/r/70041/diff/4/
Changes: https://reviews.apache.org/r/70041/diff/3-4/
Testing
-------
Pre-commit tests run: https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/932/
Thanks,
madhan
Re: Review Request 70041: ATLAS-3056: updated rdbms types to remove
use of ownedRef/inverseRef
Posted by .
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70041/
-----------------------------------------------------------
(Updated Feb. 22, 2019, 6:44 p.m.)
Review request for atlas, Ashutosh Mestry, keval bhatt, Nikhil Bonte, Nixon Rodrigues, and Sarath Subramanian.
Changes
-------
updated to address the review comments.
Bugs: ATLAS-3056
https://issues.apache.org/jira/browse/ATLAS-3056
Repository: atlas
Description
-------
- updated RDBMS model to remove attributes that use ownedRef/inverseRef constraints
- updated corresponding relationship-types as COMPOSITION
- updated notification processing to fix notifications of earlier model for the model changes
Diffs (updated)
-----
addons/models/2000-RDBMS/2010-rdbms_model.json 386446c8c
webapp/src/main/java/org/apache/atlas/notification/NotificationHookConsumer.java 6d03ba492
webapp/src/main/java/org/apache/atlas/notification/preprocessor/EntityPreprocessor.java bdea14adf
webapp/src/main/java/org/apache/atlas/notification/preprocessor/RdbmsPreprocessor.java PRE-CREATION
Diff: https://reviews.apache.org/r/70041/diff/3/
Changes: https://reviews.apache.org/r/70041/diff/2-3/
Testing
-------
Pre-commit tests run: https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/932/
Thanks,
madhan
Re: Review Request 70041: ATLAS-3056: updated rdbms types to remove
use of ownedRef/inverseRef
Posted by .
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70041/
-----------------------------------------------------------
(Updated Feb. 22, 2019, 3:28 a.m.)
Review request for atlas, Ashutosh Mestry, keval bhatt, Nikhil Bonte, Nixon Rodrigues, and Sarath Subramanian.
Bugs: ATLAS-3056
https://issues.apache.org/jira/browse/ATLAS-3056
Repository: atlas
Description
-------
- updated RDBMS model to remove attributes that use ownedRef/inverseRef constraints
- updated corresponding relationship-types as COMPOSITION
- updated notification processing to fix notifications of earlier model for the model changes
Diffs (updated)
-----
addons/models/2000-RDBMS/2010-rdbms_model.json 386446c8c
webapp/src/main/java/org/apache/atlas/notification/NotificationHookConsumer.java 6d03ba492
webapp/src/main/java/org/apache/atlas/notification/preprocessor/EntityPreprocessor.java bdea14adf
webapp/src/main/java/org/apache/atlas/notification/preprocessor/RdbmsPreprocessor.java PRE-CREATION
Diff: https://reviews.apache.org/r/70041/diff/2/
Changes: https://reviews.apache.org/r/70041/diff/1-2/
Testing
-------
Pre-commit tests run: https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/932/
Thanks,
madhan