You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/04/09 02:59:21 UTC
[GitHub] [apisix-dashboard] okaybase opened a new pull request, #2417: chore: update the year of copyright and fix typo
okaybase opened a new pull request, #2417:
URL: https://github.com/apache/apisix-dashboard/pull/2417
Please answer these questions before submitting a pull request, **or your PR will get closed**.
**Why submit this pull request?**
- [x] Bugfix
- [ ] New feature provided
- [ ] Improve performance
- [ ] Backport patches
**What changes will this PR take into?**
Update the year of copyright and fix typo.
**Checklist:**
- [x] Did you explain what problem does this PR solve? Or what new features have been added?
- [ ] Have you added corresponding test cases?
- [x] Have you modified the corresponding document?
- [x] Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-commenter commented on pull request #2417: chore: update the year of copyright and fix typo
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #2417:
URL: https://github.com/apache/apisix-dashboard/pull/2417#issuecomment-1093636139
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2417?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#2417](https://codecov.io/gh/apache/apisix-dashboard/pull/2417?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4541362) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/457393ae241235ca1a7b6aec9165fe3d4c737039?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (457393a) will **not change** coverage.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #2417 +/- ##
=======================================
Coverage 68.57% 68.57%
=======================================
Files 131 131
Lines 3421 3421
Branches 828 828
=======================================
Hits 2346 2346
Misses 1075 1075
```
| Flag | Coverage Δ | |
|---|---|---|
| frontend-e2e-test | `68.57% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/2417?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [web/src/components/Footer/index.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2417/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL0Zvb3Rlci9pbmRleC50c3g=) | `100.00% <ø> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2417?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2417?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [457393a...4541362](https://codecov.io/gh/apache/apisix-dashboard/pull/2417?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] okaybase commented on pull request #2417: chore: update the year of copyright and fix typo
Posted by GitBox <gi...@apache.org>.
okaybase commented on PR #2417:
URL: https://github.com/apache/apisix-dashboard/pull/2417#issuecomment-1093678756
> LGTM with a proposal. WDYT @okaybase?
done~ thanks~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] bisakhmondal commented on a diff in pull request #2417: chore: update the year of copyright and fix typo
Posted by GitBox <gi...@apache.org>.
bisakhmondal commented on code in PR #2417:
URL: https://github.com/apache/apisix-dashboard/pull/2417#discussion_r846577624
##########
web/src/components/Footer/index.tsx:
##########
@@ -20,7 +20,7 @@ import { DefaultFooter } from '@ant-design/pro-layout';
export default () => (
<DefaultFooter
- copyright="2021 Apache APISIX"
+ copyright=`${new Date().getFullYear()} Apache APISIX`
Review Comment:
```suggestion
copyright={`${new Date().getFullYear()} Apache APISIX`}
```
Ahh, missed suggesting a wrap. CI should be fine now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] bisakhmondal commented on a diff in pull request #2417: chore: update the year of copyright and fix typo
Posted by GitBox <gi...@apache.org>.
bisakhmondal commented on code in PR #2417:
URL: https://github.com/apache/apisix-dashboard/pull/2417#discussion_r846571405
##########
web/src/components/Footer/index.tsx:
##########
@@ -20,7 +20,7 @@ import { DefaultFooter } from '@ant-design/pro-layout';
export default () => (
<DefaultFooter
- copyright="2021 Apache APISIX"
+ copyright="2022 Apache APISIX"
Review Comment:
How about making it dynamic so that we don't have to update it every year?
```suggestion
copyright=`${new Date().getFullYear()} Apache APISIX`
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] okaybase merged pull request #2417: chore: update the year of copyright and fix typo
Posted by GitBox <gi...@apache.org>.
okaybase merged PR #2417:
URL: https://github.com/apache/apisix-dashboard/pull/2417
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org