You are viewing a plain text version of this content. The canonical link for it is here.
Posted to fx-dev@ws.apache.org by Ruchith Fernando <ru...@gmail.com> on 2005/06/01 07:08:06 UTC

[patch]WS-Trust Impl

HI,

I refactored the org.apache.ws.security.trust.message.token.* classes
of the WS-Trust impl.

Changes:

* RequestSecurityToken, RequestSecurityTokenResponse,
RequestedProofToken, RequestedSecurityToken were moved into the Trust
Impl. where they actually belong.

* All the WS-Trust related security token classes extends from AbstractToken 
  Removed the unnecessary methods from these classes and added missing ones

* Added a few missing tokens: RenewTarget, Claims

ws-trust_patch_01_06_2005.txt - Changes to files in the wss4j/src
source directory
ws-trust_tests_patch_01_06_2005.txt - Changes to files in the
wss4j/test source directory

Can someone please apply the patches. :-)

Thanks,
Ruchith

Re: [patch]WS-Trust Impl

Posted by Ruchith Fernando <ru...@gmail.com>.
CORRECTION:

- RENAME "org.apache.ws.security.trust.message.token.LifeTime.java" FILE to
 "org.apache.ws.security.trust.message.token.Lifetime.java"

> - RENAME "org.apache.ws.security.trust.message.token.LifeTime.java" FILE to
> "org.apache.ws.security.trust.message.token.Lifetime"

Thanks,
Ruchith

On 6/1/05, Ruchith Fernando <ru...@gmail.com> wrote:
> Hi Dims,
> 
> Oops, I'm looking into the tests now. Will send in the patches soon. :-)
> 
> In the meantime can please do the following changes if possible:
> 
> - RENAME "org.apache.ws.security.conversation.dkAlgo" PACKAGE to
> "org.apache.ws.security.conversation.dkalgo"
> 
> - RENAME "org.apache.ws.security.trust.message.token.LifeTime.java" FILE to
> "org.apache.ws.security.trust.message.token.Lifetime"
> 
> Those changes were not reflected in the CVS!
> 
> Thanks
> Ruchith
> 
> On 6/1/05, Davanum Srinivas <da...@gmail.com> wrote:
> > Ruchith,
> >
> > Checked in the files...Can you please fix the test cases in
> > "secconv/components/PackageTests" and send in a new patch? the tests
> > are failing.
> >
> > thanks,
> > dims
> >
> > On 6/1/05, Ruchith Fernando <ru...@gmail.com> wrote:
> > > HI,
> > >
> > > I refactored the org.apache.ws.security.trust.message.token.* classes
> > > of the WS-Trust impl.
> > >
> > > Changes:
> > >
> > > * RequestSecurityToken, RequestSecurityTokenResponse,
> > > RequestedProofToken, RequestedSecurityToken were moved into the Trust
> > > Impl. where they actually belong.
> > >
> > > * All the WS-Trust related security token classes extends from AbstractToken
> > >   Removed the unnecessary methods from these classes and added missing ones
> > >
> > > * Added a few missing tokens: RenewTarget, Claims
> > >
> > > ws-trust_patch_01_06_2005.txt - Changes to files in the wss4j/src
> > > source directory
> > > ws-trust_tests_patch_01_06_2005.txt - Changes to files in the
> > > wss4j/test source directory
> > >
> > > Can someone please apply the patches. :-)
> > >
> > > Thanks,
> > > Ruchith
> > >
> > >
> > >
> >
> >
> > --
> > Davanum Srinivas - http://webservices.apache.org/~dims/
> >
> 
> 
> --
> Ruchith Fernando
> www.ruchith.org
>

Re: [patch]WS-Trust Impl

Posted by Davanum Srinivas <da...@gmail.com>.
done.

On 6/1/05, Ruchith Fernando <ru...@gmail.com> wrote:
> Hi Dims,
> 
> Oops, I'm looking into the tests now. Will send in the patches soon. :-)
> 
> In the meantime can please do the following changes if possible:
> 
> - RENAME "org.apache.ws.security.conversation.dkAlgo" PACKAGE to
> "org.apache.ws.security.conversation.dkalgo"
> 
> - RENAME "org.apache.ws.security.trust.message.token.LifeTime.java" FILE to
> "org.apache.ws.security.trust.message.token.Lifetime"
> 
> Those changes were not reflected in the CVS!
> 
> Thanks
> Ruchith
> 
> On 6/1/05, Davanum Srinivas <da...@gmail.com> wrote:
> > Ruchith,
> >
> > Checked in the files...Can you please fix the test cases in
> > "secconv/components/PackageTests" and send in a new patch? the tests
> > are failing.
> >
> > thanks,
> > dims
> >
> > On 6/1/05, Ruchith Fernando <ru...@gmail.com> wrote:
> > > HI,
> > >
> > > I refactored the org.apache.ws.security.trust.message.token.* classes
> > > of the WS-Trust impl.
> > >
> > > Changes:
> > >
> > > * RequestSecurityToken, RequestSecurityTokenResponse,
> > > RequestedProofToken, RequestedSecurityToken were moved into the Trust
> > > Impl. where they actually belong.
> > >
> > > * All the WS-Trust related security token classes extends from AbstractToken
> > >   Removed the unnecessary methods from these classes and added missing ones
> > >
> > > * Added a few missing tokens: RenewTarget, Claims
> > >
> > > ws-trust_patch_01_06_2005.txt - Changes to files in the wss4j/src
> > > source directory
> > > ws-trust_tests_patch_01_06_2005.txt - Changes to files in the
> > > wss4j/test source directory
> > >
> > > Can someone please apply the patches. :-)
> > >
> > > Thanks,
> > > Ruchith
> > >
> > >
> > >
> >
> >
> > --
> > Davanum Srinivas - http://webservices.apache.org/~dims/
> >
> 
> 
> --
> Ruchith Fernando
> www.ruchith.org
> 


-- 
Davanum Srinivas - http://webservices.apache.org/~dims/

Re: [patch]WS-Trust Impl

Posted by Ruchith Fernando <ru...@gmail.com>.
Hi Dims,

Oops, I'm looking into the tests now. Will send in the patches soon. :-)

In the meantime can please do the following changes if possible:

- RENAME "org.apache.ws.security.conversation.dkAlgo" PACKAGE to
"org.apache.ws.security.conversation.dkalgo"

- RENAME "org.apache.ws.security.trust.message.token.LifeTime.java" FILE to
"org.apache.ws.security.trust.message.token.Lifetime"

Those changes were not reflected in the CVS!

Thanks
Ruchith

On 6/1/05, Davanum Srinivas <da...@gmail.com> wrote:
> Ruchith,
> 
> Checked in the files...Can you please fix the test cases in
> "secconv/components/PackageTests" and send in a new patch? the tests
> are failing.
> 
> thanks,
> dims
> 
> On 6/1/05, Ruchith Fernando <ru...@gmail.com> wrote:
> > HI,
> >
> > I refactored the org.apache.ws.security.trust.message.token.* classes
> > of the WS-Trust impl.
> >
> > Changes:
> >
> > * RequestSecurityToken, RequestSecurityTokenResponse,
> > RequestedProofToken, RequestedSecurityToken were moved into the Trust
> > Impl. where they actually belong.
> >
> > * All the WS-Trust related security token classes extends from AbstractToken
> >   Removed the unnecessary methods from these classes and added missing ones
> >
> > * Added a few missing tokens: RenewTarget, Claims
> >
> > ws-trust_patch_01_06_2005.txt - Changes to files in the wss4j/src
> > source directory
> > ws-trust_tests_patch_01_06_2005.txt - Changes to files in the
> > wss4j/test source directory
> >
> > Can someone please apply the patches. :-)
> >
> > Thanks,
> > Ruchith
> >
> >
> >
> 
> 
> --
> Davanum Srinivas - http://webservices.apache.org/~dims/
> 


-- 
Ruchith Fernando
www.ruchith.org

Re: [patch]WS-Trust Impl - test cases fixed :-)

Posted by Ruchith Fernando <ru...@gmail.com>.
Hi,

I fixed the tests that failed in secconv.components.* package

The problems were due to:
- Incorrect initialization of xml-sec
- Hardcoded namespace in org.apache.ws.security.conversation.ConversationManager

Please apply the attached patches.

ws-sc_patch_02_06_2005.txt - diff on the wss4j/src
ws-sc_tests_patch_02_06_2005.txt - diff on the wss4j/test

Thanks
Ruchith

On 6/1/05, Davanum Srinivas <da...@gmail.com> wrote:
> Ruchith,
> 
> Checked in the files...Can you please fix the test cases in
> "secconv/components/PackageTests" and send in a new patch? the tests
> are failing.
> 
> thanks,
> dims
> 
> On 6/1/05, Ruchith Fernando <ru...@gmail.com> wrote:
> > HI,
> >
> > I refactored the org.apache.ws.security.trust.message.token.* classes
> > of the WS-Trust impl.
> >
> > Changes:
> >
> > * RequestSecurityToken, RequestSecurityTokenResponse,
> > RequestedProofToken, RequestedSecurityToken were moved into the Trust
> > Impl. where they actually belong.
> >
> > * All the WS-Trust related security token classes extends from AbstractToken
> >   Removed the unnecessary methods from these classes and added missing ones
> >
> > * Added a few missing tokens: RenewTarget, Claims
> >
> > ws-trust_patch_01_06_2005.txt - Changes to files in the wss4j/src
> > source directory
> > ws-trust_tests_patch_01_06_2005.txt - Changes to files in the
> > wss4j/test source directory
> >
> > Can someone please apply the patches. :-)
> >
> > Thanks,
> > Ruchith
> >
> >
> >
> 
> 
> --
> Davanum Srinivas - http://webservices.apache.org/~dims/
> 


-- 
Ruchith Fernando
www.ruchith.org

Re: [patch]WS-Trust Impl

Posted by Davanum Srinivas <da...@gmail.com>.
Ruchith,

Checked in the files...Can you please fix the test cases in
"secconv/components/PackageTests" and send in a new patch? the tests
are failing.

thanks,
dims

On 6/1/05, Ruchith Fernando <ru...@gmail.com> wrote:
> HI,
> 
> I refactored the org.apache.ws.security.trust.message.token.* classes
> of the WS-Trust impl.
> 
> Changes:
> 
> * RequestSecurityToken, RequestSecurityTokenResponse,
> RequestedProofToken, RequestedSecurityToken were moved into the Trust
> Impl. where they actually belong.
> 
> * All the WS-Trust related security token classes extends from AbstractToken
>   Removed the unnecessary methods from these classes and added missing ones
> 
> * Added a few missing tokens: RenewTarget, Claims
> 
> ws-trust_patch_01_06_2005.txt - Changes to files in the wss4j/src
> source directory
> ws-trust_tests_patch_01_06_2005.txt - Changes to files in the
> wss4j/test source directory
> 
> Can someone please apply the patches. :-)
> 
> Thanks,
> Ruchith
> 
> 
> 


-- 
Davanum Srinivas - http://webservices.apache.org/~dims/