You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@plc4x.apache.org by sr...@apache.org on 2019/12/18 10:41:07 UTC
[plc4x] 03/05: [plc4j-api] change values to package private
This is an automated email from the ASF dual-hosted git repository.
sruehl pushed a commit to branch next-gen-core
in repository https://gitbox.apache.org/repos/asf/plc4x.git
commit 563c418509f8a522e126738a6d7eafd6e4a26d94
Author: Sebastian Rühl <sr...@apache.org>
AuthorDate: Tue Dec 17 18:47:26 2019 +0100
[plc4j-api] change values to package private
---
.../org/apache/plc4x/java/api/value/PlcBoolean.java | 4 ++--
.../org/apache/plc4x/java/api/value/PlcInteger.java | 4 ++--
.../java/org/apache/plc4x/java/api/value/PlcList.java | 2 +-
.../org/apache/plc4x/java/api/value/PlcSimpleValue.java | 17 +++++++++--------
.../java/org/apache/plc4x/java/api/value/PlcString.java | 2 +-
.../java/org/apache/plc4x/java/api/value/PlcStruct.java | 2 +-
6 files changed, 16 insertions(+), 15 deletions(-)
diff --git a/plc4j/api/src/main/java/org/apache/plc4x/java/api/value/PlcBoolean.java b/plc4j/api/src/main/java/org/apache/plc4x/java/api/value/PlcBoolean.java
index 1c0cc0c..69d4702 100644
--- a/plc4j/api/src/main/java/org/apache/plc4x/java/api/value/PlcBoolean.java
+++ b/plc4j/api/src/main/java/org/apache/plc4x/java/api/value/PlcBoolean.java
@@ -2,11 +2,11 @@ package org.apache.plc4x.java.api.value;
public class PlcBoolean extends PlcSimpleValue<Boolean> {
- public PlcBoolean(Boolean value) {
+ PlcBoolean(Boolean value) {
super(value, true);
}
- public PlcBoolean(boolean bool) {
+ PlcBoolean(boolean bool) {
super(bool, false);
}
diff --git a/plc4j/api/src/main/java/org/apache/plc4x/java/api/value/PlcInteger.java b/plc4j/api/src/main/java/org/apache/plc4x/java/api/value/PlcInteger.java
index 8b7e03c..069a67d 100644
--- a/plc4j/api/src/main/java/org/apache/plc4x/java/api/value/PlcInteger.java
+++ b/plc4j/api/src/main/java/org/apache/plc4x/java/api/value/PlcInteger.java
@@ -4,11 +4,11 @@ import org.apache.plc4x.java.api.value.PlcSimpleValue;
public class PlcInteger extends PlcSimpleValue<Integer> {
- public PlcInteger(Integer value) {
+ PlcInteger(Integer value) {
super(value, true);
}
- public PlcInteger(int value) {
+ PlcInteger(int value) {
super(value, false);
}
diff --git a/plc4j/api/src/main/java/org/apache/plc4x/java/api/value/PlcList.java b/plc4j/api/src/main/java/org/apache/plc4x/java/api/value/PlcList.java
index e307d61..2f4b7a0 100644
--- a/plc4j/api/src/main/java/org/apache/plc4x/java/api/value/PlcList.java
+++ b/plc4j/api/src/main/java/org/apache/plc4x/java/api/value/PlcList.java
@@ -11,7 +11,7 @@ public class PlcList extends PlcValueAdapter {
private final List<PlcValue> listItems;
- public PlcList(List<PlcValue> listItems) {
+ PlcList(List<PlcValue> listItems) {
this.listItems = Collections.unmodifiableList(listItems);
}
diff --git a/plc4j/api/src/main/java/org/apache/plc4x/java/api/value/PlcSimpleValue.java b/plc4j/api/src/main/java/org/apache/plc4x/java/api/value/PlcSimpleValue.java
index 37e4ef7..0148bf9 100644
--- a/plc4j/api/src/main/java/org/apache/plc4x/java/api/value/PlcSimpleValue.java
+++ b/plc4j/api/src/main/java/org/apache/plc4x/java/api/value/PlcSimpleValue.java
@@ -1,26 +1,27 @@
package org.apache.plc4x.java.api.value;
-import org.apache.plc4x.java.api.value.PlcValueAdapter;
-
public abstract class PlcSimpleValue<T> extends PlcValueAdapter {
- protected final T value;
- protected final boolean isNullable;
+ final T value;
+ final boolean isNullable;
- public PlcSimpleValue(T value, boolean isNullable) {
+ PlcSimpleValue(T value, boolean isNullable) {
this.value = value;
this.isNullable = isNullable;
}
- @Override public boolean isSimple() {
+ @Override
+ public boolean isSimple() {
return true;
}
- @Override public boolean isNullable() {
+ @Override
+ public boolean isNullable() {
return isNullable;
}
- @Override public boolean isNull() {
+ @Override
+ public boolean isNull() {
return isNullable && value == null;
}
diff --git a/plc4j/api/src/main/java/org/apache/plc4x/java/api/value/PlcString.java b/plc4j/api/src/main/java/org/apache/plc4x/java/api/value/PlcString.java
index ea12bb4..ba4a2a5 100644
--- a/plc4j/api/src/main/java/org/apache/plc4x/java/api/value/PlcString.java
+++ b/plc4j/api/src/main/java/org/apache/plc4x/java/api/value/PlcString.java
@@ -2,7 +2,7 @@ package org.apache.plc4x.java.api.value;
public class PlcString extends PlcSimpleValue<String> {
- public PlcString(String value) {
+ PlcString(String value) {
super(value, true);
}
diff --git a/plc4j/api/src/main/java/org/apache/plc4x/java/api/value/PlcStruct.java b/plc4j/api/src/main/java/org/apache/plc4x/java/api/value/PlcStruct.java
index 82d0fd7..7e89536 100644
--- a/plc4j/api/src/main/java/org/apache/plc4x/java/api/value/PlcStruct.java
+++ b/plc4j/api/src/main/java/org/apache/plc4x/java/api/value/PlcStruct.java
@@ -12,7 +12,7 @@ public class PlcStruct extends PlcValueAdapter {
private final Map<String, PlcValue> map;
- public PlcStruct(Map<String, PlcValue> map) {
+ PlcStruct(Map<String, PlcValue> map) {
this.map = Collections.unmodifiableMap(map);
}