You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@iceberg.apache.org by "manuzhang (via GitHub)" <gi...@apache.org> on 2026/05/20 16:11:19 UTC

[I] Remove deprecated methods for 1.12.0 [iceberg]

manuzhang opened a new issue, #16445:
URL: https://github.com/apache/iceberg/issues/16445

   Methods marked with `@deprecated ... will be removed in 1.12.0` needs to be removed now since 1.11.0 is released.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org

Re: [I] Remove deprecated methods for 1.12.0 [iceberg]

Posted by "manuzhang (via GitHub)" <gi...@apache.org>.

manuzhang commented on issue #16445:
URL: https://github.com/apache/iceberg/issues/16445#issuecomment-5336626104

   #16449 was split into following smaller PRs by @dramaticlly 
   
     - #17444
     - #17623
     - #17624
     - #17625
     - #17626
     - #17627
     - #17638
     - #17696
     - #17697
     - #17698
     - #17699
     - #17700
     - #17702
     - #17703
     - #17704
     - #17706


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org

Re: [I] Remove deprecated methods for 1.12.0 [iceberg]

Posted by "kinolaev (via GitHub)" <gi...@apache.org>.

kinolaev commented on issue #16445:
URL: https://github.com/apache/iceberg/issues/16445#issuecomment-5446582535

   @manuzhang, @dramaticlly, shouldn't `org.apache.iceberg.avro.Avro.ReadBuilder.createReaderFunc` and `org.apache.iceberg.avro.ProjectionDatumReader` also be removed? It seems like they were used only with `DataReader`, but now the `org.apache.iceberg.avro.TestReadDefaultValues.testDefaultDoesNotOverrideExplicitValue` test is the only caller. And the test succeed without `.createReaderFunc(GenericAvroReader::create)` call, because `GenericAvroReader` is the default reader in `Avro.ReadBuilder`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org

Re: [I] Remove deprecated methods for 1.12.0 [iceberg]

Posted by "michaelmitchell-bit (via GitHub)" <gi...@apache.org>.

michaelmitchell-bit commented on issue #16445:
URL: https://github.com/apache/iceberg/issues/16445#issuecomment-4618758249

   Hi! I’d like to take a small pass at this, starting with one module rather than trying to remove everything in a single large PR. I’m going to look for APIs deprecated for removal in 1.12.0, likely begin with core, and update any call sites/tests that fall out of that. I’ll keep the PR focused so it’s easier to review.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org

Re: [I] Remove deprecated methods for 1.12.0 [iceberg]

Posted by "brucearctor (via GitHub)" <gi...@apache.org>.

brucearctor commented on issue #16445:
URL: https://github.com/apache/iceberg/issues/16445#issuecomment-5018465877

   @manuzhang  -- should @dramaticlly be assigned here?  So, it is clear someone assigned & working on this?  


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org

Re: [I] Remove deprecated methods for 1.12.0 [iceberg]

Posted by "manuzhang (via GitHub)" <gi...@apache.org>.

manuzhang commented on issue #16445:
URL: https://github.com/apache/iceberg/issues/16445#issuecomment-5447451549

   @kinolaev Yes, pubic class should be marked as `@deprecated` first.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org

Re: [I] Remove deprecated methods for 1.12.0 [iceberg]

Posted by "raushanprabhakar1 (via GitHub)" <gi...@apache.org>.

raushanprabhakar1 commented on issue #16445:
URL: https://github.com/apache/iceberg/issues/16445#issuecomment-4501244050

   Hi @manuzhang , I think it would be really large PR if we do this once, ideally we should raise PR module wise like handling deprecation in core module once, Data in one, likewise?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org

Re: [I] Remove deprecated methods for 1.12.0 [iceberg]

Posted by "nssalian (via GitHub)" <gi...@apache.org>.

nssalian commented on issue #16445:
URL: https://github.com/apache/iceberg/issues/16445#issuecomment-5303403441

   @enesyesil it's already in progress with @dramaticlly's active work. Would you be able to assist in reviewing?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org

Re: [I] Remove deprecated methods for 1.12.0 [iceberg]

Posted by "Aazim-parwaz (via GitHub)" <gi...@apache.org>.

Aazim-parwaz commented on issue #16445:
URL: https://github.com/apache/iceberg/issues/16445#issuecomment-4757656717

   Hi @manuzhang , I’d like to work on this issue.
   I’ve started looking into the deprecated methods and will begin by identifying all usages across the codebase and checking what can be safely removed.
   Please let me know if someone is already working on it. Thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org

Re: [I] Remove deprecated methods for 1.12.0 [iceberg]

Posted by "manuzhang (via GitHub)" <gi...@apache.org>.

manuzhang commented on issue #16445:
URL: https://github.com/apache/iceberg/issues/16445#issuecomment-4757671185

   Hi @Aazim-parwaz, @dramaticlly is already working on it in #16449


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org

Re: [I] Remove deprecated methods for 1.12.0 [iceberg]

Posted by "nssalian (via GitHub)" <gi...@apache.org>.

nssalian commented on issue #16445:
URL: https://github.com/apache/iceberg/issues/16445#issuecomment-5223782177

   @shottah https://github.com/apache/iceberg/pull/16449 this is added to the milestone and should cover it altogther. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org

Re: [I] Remove deprecated methods for 1.12.0 [iceberg]

Posted by "shottah (via GitHub)" <gi...@apache.org>.

shottah commented on issue #16445:
URL: https://github.com/apache/iceberg/issues/16445#issuecomment-5223765655

   Also is this still part of the 1.12.0 build or no? Since it was removed from the milestone.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org

Re: [I] Remove deprecated methods for 1.12.0 [iceberg]

Posted by "omnipotentchaos (via GitHub)" <gi...@apache.org>.

omnipotentchaos commented on issue #16445:
URL: https://github.com/apache/iceberg/issues/16445#issuecomment-4501094041

   Hi, I would like to work on this issue. Can you please assign it to me? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org

Re: [I] Remove deprecated methods for 1.12.0 [iceberg]

Posted by "enesyesil (via GitHub)" <gi...@apache.org>.

enesyesil commented on issue #16445:
URL: https://github.com/apache/iceberg/issues/16445#issuecomment-5299589528

   Hey, is this still open? I’d like to take it. Thanks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org