You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2018/12/29 20:30:37 UTC

[GitHub] stale[bot] closed pull request #4127: Bug Fix: Secrets object and key separated by ":"

stale[bot] closed pull request #4127: Bug Fix: Secrets object and key separated by ":"
URL: https://github.com/apache/incubator-airflow/pull/4127
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/airflow/contrib/kubernetes/worker_configuration.py b/airflow/contrib/kubernetes/worker_configuration.py
index 74658e384a..83fa93e431 100644
--- a/airflow/contrib/kubernetes/worker_configuration.py
+++ b/airflow/contrib/kubernetes/worker_configuration.py
@@ -97,7 +97,7 @@ def _get_secrets(self):
         """Defines any necessary secrets for the pod executor"""
         worker_secrets = []
         for env_var_name, obj_key_pair in six.iteritems(self.kube_config.kube_secrets):
-            k8s_secret_obj, k8s_secret_key = obj_key_pair.split('=')
+            k8s_secret_obj, k8s_secret_key = obj_key_pair.split(':')
             worker_secrets.append(
                 Secret('env', env_var_name, k8s_secret_obj, k8s_secret_key))
         return worker_secrets


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services