You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/05/07 11:32:01 UTC

[GitHub] [kafka] satishd commented on a change in pull request #10638: KAFKA-12758 Added `server-common` module to have server side common classes.

satishd commented on a change in pull request #10638:
URL: https://github.com/apache/kafka/pull/10638#discussion_r628138696



##########
File path: build.gradle
##########
@@ -1585,6 +1644,7 @@ project(':shell') {
     implementation libs.jacksonJDK8Datatypes
     implementation libs.jline
     implementation libs.slf4jApi
+    implementation project(':server-common')

Review comment:
       Right, this is needed because `core` module does not expose `server-common` as a transitive module with gradle `api` dependency. It uses `implementation` dependency for `server-common` to be part of `core` module's compile/runtime classpaths.
   
   I am not sure whether we really have usages for `server-common` classes to be exposed as part of `core` module.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org