You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by Arieh Markel <Ar...@central.sun.com> on 2000/09/27 01:42:35 UTC
Issue with org.apache.tomcat.service.http.HttpInterceptor
I downloaded yesterday the latest snapshot of the 3.2 tree.
On trying to adapt my application to the changes in the implementation
of Tomcat (which we embed), I am running into a couple of issues
with the 'org.apache.tomcat.service.http.HttpInterceptor' class.
Not all the 'set' methods include their 'get' counterpart.
For example, I would like to be able to have a
public boolean isSecure()
method to stand opposite to 'public void setSecure(boolean)'.
Also there is a general purpose:
public void setAttribute (String, Object)
but no counterpart:
public Object getAttribute (String)
I am wondering whether this is an oversight.
Thanks,
Arieh
PS: If agreed that this is useful, I can make the appropriate changes,
just need some direction as far as where the CVS repository is on
'locus' (given that I was awarded committer status a couple of weeks
ago).
--
Arieh Markel Sun Microsystems Inc.
Network Storage 500 Eldorado Blvd. MS UBRM11-194
e-mail: arieh.markel@sun.COM Broomfield, CO 80021
Let's go Panthers !!!! Phone: (303) 272-8547 x78547
(e-mail me with subject SEND PUBLIC KEY to get public key)
Re: Issue with org.apache.tomcat.service.http.HttpInterceptor
Posted by "Craig R. McClanahan" <Cr...@eng.sun.com>.
Arieh Markel wrote:
> I downloaded yesterday the latest snapshot of the 3.2 tree.
>
> On trying to adapt my application to the changes in the implementation
> of Tomcat (which we embed), I am running into a couple of issues
> with the 'org.apache.tomcat.service.http.HttpInterceptor' class.
>
> Not all the 'set' methods include their 'get' counterpart.
>
> For example, I would like to be able to have a
>
> public boolean isSecure()
>
> method to stand opposite to 'public void setSecure(boolean)'.
>
> Also there is a general purpose:
>
> public void setAttribute (String, Object)
>
> but no counterpart:
>
> public Object getAttribute (String)
>
>
> I am wondering whether this is an oversight.
>
I don't see HttpInterceptor.java on the 3.2 branch -- isn't it only in the
main branch?
FWIW, I think the changes you are suggesting seem quite reasonable.
>
> Thanks,
>
> Arieh
>
> PS: If agreed that this is useful, I can make the appropriate changes,
> just need some direction as far as where the CVS repository is on
> 'locus' (given that I was awarded committer status a couple of weeks
> ago).
The 3.2 tree is in the "jakarta-tomcat" module, on a branch named
"tomcat_32".
You'll need the software tools described on the Jakarta web site to access
CVS through SSH for doing commits.
> Arieh Markel Sun Microsystems Inc.
>
Craig
====================
See you at ApacheCon Europe <http://www.apachecon.com>!
Session VS01 (23-Oct 13h00-17h00): Sun Technical Briefing
Session T06 (24-Oct 14h00-15h00): Migrating Apache JServ
Applications to Tomcat
Re: Issue with org.apache.tomcat.service.http.HttpInterceptor
Posted by cm...@yahoo.com.
Hi,
HttpInterceptor is part of 3.3 tree.
....service.http.HttpInterceptor will be deprecated - as the whole
service package.
I did a major refactoring of the whole package, and moved it to
org.apache.tomcat.modules.server
The main change is the move from Connector to normal Interceptors. This
allows server adapters to participate in all request processing stages,
and will help in many ways - delaying expensive operations, better
integration, etc.
It also simplifies the setup - now the same mechanism is used instead of
the old parameter name/value hack. Please take a look at the new code.
As a commiter you can change anything
you want and feel is useful in the development branch. We use
"commit-then-review" mechanism - i.e. if anyone feels your change is
not good can -1 it ( I don't think that happened more than 1-2 times
). Don't worry if you brake something - everything can be fixed, as
long as you feel the change is worth it.
After 3.3 I hope no major change will happen in core, and I'll propose a
"review-than-commit" policy for the core ( i.e. try to keep the internal
API as stable as possible, so that interceptors and facades can be
developed and improved ). Of course, if anyone will have good ideas to
improve the core after 3.3 I'm sure that will happen, but I think we are
close to something simple and good enough.
Costin
> I downloaded yesterday the latest snapshot of the 3.2 tree.
>
> On trying to adapt my application to the changes in the implementation
> of Tomcat (which we embed), I am running into a couple of issues
> with the 'org.apache.tomcat.service.http.HttpInterceptor' class.
>
> Not all the 'set' methods include their 'get' counterpart.
>
> For example, I would like to be able to have a
>
> public boolean isSecure()
>
> method to stand opposite to 'public void setSecure(boolean)'.
>
> Also there is a general purpose:
>
> public void setAttribute (String, Object)
>
> but no counterpart:
>
> public Object getAttribute (String)
>
>
> I am wondering whether this is an oversight.
>
> Thanks,
>
> Arieh
>
> PS: If agreed that this is useful, I can make the appropriate changes,
> just need some direction as far as where the CVS repository is on
> 'locus' (given that I was awarded committer status a couple of weeks
> ago).
> --
> Arieh Markel Sun Microsystems Inc.
> Network Storage 500 Eldorado Blvd. MS UBRM11-194
> e-mail: arieh.markel@sun.COM Broomfield, CO 80021
> Let's go Panthers !!!! Phone: (303) 272-8547 x78547
> (e-mail me with subject SEND PUBLIC KEY to get public key)
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org
>