You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by "jdeppe-pivotal (GitHub)" <gi...@apache.org> on 2018/11/06 14:37:33 UTC
[GitHub] [geode] jdeppe-pivotal opened pull request #2790:
GEODE-5995: Initial import of gradle docker plugin
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
- [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?
- [ ] Is your initial contribution a single, squashed commit?
- [ ] Does `gradlew build` run cleanly?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.
[ Full content available at: https://github.com/apache/geode/pull/2790 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] jdeppe-pivotal commented on pull request #2790:
GEODE-5995: Initial import of gradle docker plugin
Posted by "jdeppe-pivotal (GitHub)" <gi...@apache.org>.
I think I was wrong on this and we don't need them at all. I guess the `buildSrc` dependencies are actually carried over.
[ Full content available at: https://github.com/apache/geode/pull/2790 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] metatype commented on pull request #2790:
GEODE-5995: Initial import of gradle docker plugin
Posted by "metatype (GitHub)" <gi...@apache.org>.
Are these dependencies of the plugin? Is it possible to declare them on the plugin itself? Is the docker-java line needed since it's already in buildSrc?
[ Full content available at: https://github.com/apache/geode/pull/2790 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] jdeppe-pivotal commented on pull request #2790:
GEODE-5995: Initial import of gradle docker plugin
Posted by "jdeppe-pivotal (GitHub)" <gi...@apache.org>.
Since the plugin is actually in buildSrc, I don't believe that buildSrc itself can export or declare its own dependencies. I could not see how to do that. The only thing it produces is `buildSrc.jar` which would need to be 'shaded' perhaps?
[ Full content available at: https://github.com/apache/geode/pull/2790 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] metatype commented on pull request #2790:
GEODE-5995: Initial import of gradle docker plugin
Posted by "metatype (GitHub)" <gi...@apache.org>.
Is this still necessary since the plugin has been imported?
[ Full content available at: https://github.com/apache/geode/pull/2790 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] jdeppe-pivotal closed pull request #2790:
GEODE-5995: Initial import of gradle docker plugin
Posted by "jdeppe-pivotal (GitHub)" <gi...@apache.org>.
[ pull request closed by jdeppe-pivotal ]
[ Full content available at: https://github.com/apache/geode/pull/2790 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] jdeppe-pivotal commented on pull request #2790:
GEODE-5995: Initial import of gradle docker plugin
Posted by "jdeppe-pivotal (GitHub)" <gi...@apache.org>.
Sigh. Yes. Notice the `docker-java...-GEODE` dependency below - it's customized to support Windows. Those changes still need to be pushed upstream, but for now the dependency lives here.
[ Full content available at: https://github.com/apache/geode/pull/2790 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] metatype commented on pull request #2790:
GEODE-5995: Initial import of gradle docker plugin
Posted by "metatype (GitHub)" <gi...@apache.org>.
Is this a typo? Wondering if you meant `src/main/groovy`?
[ Full content available at: https://github.com/apache/geode/pull/2790 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] jdeppe-pivotal commented on pull request #2790:
GEODE-5995: Initial import of gradle docker plugin
Posted by "jdeppe-pivotal (GitHub)" <gi...@apache.org>.
Seems like a gradle/groovy gotcha. If your groovy code references java code then this needs to be in place since they are compiled separately. At least StackOverflow said so :)
[ Full content available at: https://github.com/apache/geode/pull/2790 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org