You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by GitBox <gi...@apache.org> on 2021/01/26 18:22:30 UTC
[GitHub] [drill] eevanwong opened a new pull request #2156: DRILL-7712: Fix issues after ZK upgrade
eevanwong opened a new pull request #2156:
URL: https://github.com/apache/drill/pull/2156
# [DRILL-7712](https://issues.apache.org/jira/browse/DRILL-7712): Fix Issues after ZK upgrade
## Description
Updated unit test so that it utilizes MappingListenerManager instead of ListenerContainer from Apache Curator which was deprecated in version 5.1.0. Curator v5.1.0 fixes NPE errors in testing phase (also described in DRILL-7843(https://issues.apache.org/jira/browse/DRILL-7843).
## Documentation
N/A
## Testing
Checked mvn test and the errors that were described are no longer there.
`[INFO] Running org.apache.drill.exec.coord.zk.TestZookeeperClient
[INFO] Tests run: 15, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.224 s - in org.apache.drill.exec.coord.zk.TestZookeeperClient
[INFO] Running org.apache.drill.exec.coord.zk.TestEphemeralStore
[INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.658 s - in org.apache.drill.exec.coord.zk.TestEphemeralStore
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.555 s - in org.apache.drill.yarn.zk.TestAmRegistration
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.063 s - in org.apache.drill.yarn.client.TestCommandLineOptions`
Errors in jdbc-all build are not found either.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [drill] eevanwong edited a comment on pull request #2156: DRILL-7712: Fix issues after ZK upgrade
Posted by GitBox <gi...@apache.org>.
eevanwong edited a comment on pull request #2156:
URL: https://github.com/apache/drill/pull/2156#issuecomment-767736643
Made another pr with a new branch instead of master branch as recommended by luocooong.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [drill] eevanwong closed pull request #2156: DRILL-7712: Fix issues after ZK upgrade
Posted by GitBox <gi...@apache.org>.
eevanwong closed pull request #2156:
URL: https://github.com/apache/drill/pull/2156
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [drill] eevanwong commented on pull request #2156: DRILL-7712: Fix issues after ZK upgrade
Posted by GitBox <gi...@apache.org>.
eevanwong commented on pull request #2156:
URL: https://github.com/apache/drill/pull/2156#issuecomment-767804123
Was the Main Build (11) cancelled due to taking too long?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [drill] eevanwong commented on pull request #2156: DRILL-7712: Fix issues after ZK upgrade
Posted by GitBox <gi...@apache.org>.
eevanwong commented on pull request #2156:
URL: https://github.com/apache/drill/pull/2156#issuecomment-776956339
Hey! So just a bit of an update, I was able to get it working in distributed mode and have been running a few of the sample and simple queries ( such as select * from cp.`employee.json` limit 10 and select * from sys.drillbits).
I'm not entirely sure what profile pass you're referring to (unless its just the mapr profile).
Also, regarding the jdbc warnings, that is solved in DRILL-7841 pr by @mkusnir (who will make the pr later today)
I'll continue into looking at the breaking changes for apache curator 5.0.0
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [drill] luocooong commented on pull request #2156: DRILL-7712: Fix issues after ZK upgrade
Posted by GitBox <gi...@apache.org>.
luocooong commented on pull request #2156:
URL: https://github.com/apache/drill/pull/2156#issuecomment-768264751
@eevanwong There will be failure on sometimes. Drill is a complex but easy-to-use system, so looking forward to you contribute (especially the test framework). If you plan to do that, it's recommended that you register a [JIRA](https://issues.apache.org) account, very convenient to assign and track tasks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [drill] eevanwong commented on pull request #2156: DRILL-7712: Fix issues after ZK upgrade
Posted by GitBox <gi...@apache.org>.
eevanwong commented on pull request #2156:
URL: https://github.com/apache/drill/pull/2156#issuecomment-767736643
Made another pr with a new branch instead of working on master branch as recommended by luocooong.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [drill] vdiravka commented on pull request #2156: DRILL-7712: Fix issues after ZK upgrade
Posted by GitBox <gi...@apache.org>.
vdiravka commented on pull request #2156:
URL: https://github.com/apache/drill/pull/2156#issuecomment-770417957
* Since it is major update of `Curator` library, we need to be sure we took into account [all breaking changes of Apache Curator 5.0 version](https://curator.apache.org/breaking-changes.html).
* And since Curator lib manages Zookeeper, @eevanwong could you please start Drill in distributed mode and try several queries to make sure Drill works fine with Zookeeper?
@vvysotskyi Do you remember some specific cases needed to be checked in scope of [update Curator lib](https://issues.apache.org/jira/browse/DRILL-7702)?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [drill] eevanwong commented on pull request #2156: DRILL-7712: Fix issues after ZK upgrade
Posted by GitBox <gi...@apache.org>.
eevanwong commented on pull request #2156:
URL: https://github.com/apache/drill/pull/2156#issuecomment-778306759
Making new pull rq
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org