You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gora.apache.org by kamaci <gi...@git.apache.org> on 2015/09/03 22:27:03 UTC
[GitHub] gora pull request: GORA-434 Documents are Not Committed Into Solr ...
GitHub user kamaci opened a pull request:
https://github.com/apache/gora/pull/38
GORA-434 Documents are Not Committed Into Solr Store
Fix for uncommitted documents which are at last buffer when buffer is not equal to default commit size.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kamaci/gora gorasolr
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/gora/pull/38.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #38
----
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] gora pull request: GORA-434 Documents are Not Committed Into Solr ...
Posted by renato2099 <gi...@git.apache.org>.
Github user renato2099 commented on a diff in the pull request:
https://github.com/apache/gora/pull/38#discussion_r38694058
--- Diff: gora-solr/src/main/java/org/apache/gora/solr/store/SolrStore.java ---
@@ -783,9 +783,7 @@ public void flush() {
@Override
public void close() {
- // In testing, the index gets closed before the commit in flush() can happen
- // so an exception gets thrown
- // flush();
+ flush();
--- End diff --
Thanks for looking into this @kamaci !
Why don't we wrap this around an exception? so if this happens again while testing at least we will not just fail but actually try to flush and notify that something went wrong.
What do you think?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] gora pull request: GORA-434 Documents are Not Committed Into Solr ...
Posted by kamaci <gi...@git.apache.org>.
Github user kamaci commented on a diff in the pull request:
https://github.com/apache/gora/pull/38#discussion_r38695505
--- Diff: gora-solr/src/main/java/org/apache/gora/solr/store/SolrStore.java ---
@@ -783,9 +783,7 @@ public void flush() {
@Override
public void close() {
- // In testing, the index gets closed before the commit in flush() can happen
- // so an exception gets thrown
- // flush();
+ flush();
--- End diff --
@renato2099 Exceptions are already caught at flush method.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] gora pull request: GORA-434 Documents are Not Committed Into Solr ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/gora/pull/38
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---