You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by "Leader Ni (JIRA)" <ji...@apache.org> on 2012/06/06 04:01:23 UTC

[jira] [Created] (ZOOKEEPER-1480) ClientCnxn(1161) can't get the current zk server add, so that - Session 0x for server null, unexpected error

Leader Ni created ZOOKEEPER-1480:
------------------------------------

             Summary: ClientCnxn(1161) can't get the current zk server add, so that - Session 0x for server null, unexpected error
                 Key: ZOOKEEPER-1480
                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1480
             Project: ZooKeeper
          Issue Type: Bug
          Components: java client
    Affects Versions: 3.3.3
            Reporter: Leader Ni
            Assignee: Leader Ni
             Fix For: 3.3.6


   When zookeeper occur an unexpected error( Not SessionExpiredException, SessionTimeoutException and EndOfStreamException), ClientCnxn(1161) will log such as the formart "Session 0x for server null, unexpected error, closing socket connection and attempting reconnect ". The log at line 1161 in zookeeper-3.3.3
   We found that, sometimes, it logs "Session 0x for server null", you know, if log null, developer can't determine the current zookeeper addr that client is connected or connecting.
   I add a method in Class SendThread:InetSocketAddress org.apache.zookeeper.ClientCnxn.SendThread.getCurrentZooKeeperAddr().



--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (ZOOKEEPER-1480) ClientCnxn(1161) can't get the current zk server add, so that - Session 0x for server null, unexpected error

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/ZOOKEEPER-1480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13289904#comment-13289904 ] 

Hadoop QA commented on ZOOKEEPER-1480:
--------------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12531055/getCurrentZooKeeperAddr.patch
  against trunk revision 1337029.

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    -1 patch.  The patch command could not apply the patch.

Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1088//console

This message is automatically generated.
                
> ClientCnxn(1161) can't get the current zk server add, so that - Session 0x for server null, unexpected error
> ------------------------------------------------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-1480
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1480
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: java client
>    Affects Versions: 3.3.3
>            Reporter: Leader Ni
>            Assignee: Leader Ni
>              Labels: client, getCurrentZooKeeperAddr
>             Fix For: 3.3.6
>
>         Attachments: getCurrentZooKeeperAddr.patch
>
>
>    When zookeeper occur an unexpected error( Not SessionExpiredException, SessionTimeoutException and EndOfStreamException), ClientCnxn(1161) will log such as the formart "Session 0x for server null, unexpected error, closing socket connection and attempting reconnect ". The log at line 1161 in zookeeper-3.3.3
>    We found that, zookeeper use "((SocketChannel)sockKey.channel()).socket().getRemoteSocketAddress()" to get zookeeper addr. But,Sometimes, it logs "Session 0x for server null", you know, if log null, developer can't determine the current zookeeper addr that client is connected or connecting.
>    I add a method in Class SendThread:InetSocketAddress org.apache.zookeeper.ClientCnxn.SendThread.getCurrentZooKeeperAddr().

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Reopened] (ZOOKEEPER-1480) ClientCnxn(1161) can't get the current zk server add, so that - Session 0x for server null, unexpected error

Posted by "Leader Ni (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/ZOOKEEPER-1480?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Leader Ni reopened ZOOKEEPER-1480:
----------------------------------

    
> ClientCnxn(1161) can't get the current zk server add, so that - Session 0x for server null, unexpected error
> ------------------------------------------------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-1480
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1480
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: java client
>    Affects Versions: 3.3.3
>            Reporter: Leader Ni
>            Assignee: Leader Ni
>              Labels: client, getCurrentZooKeeperAddr
>             Fix For: 3.4.4, 3.5.0
>
>         Attachments: getCurrentZooKeeperAddr_for_branch3.4.patch
>
>
>    When zookeeper occur an unexpected error( Not SessionExpiredException, SessionTimeoutException and EndOfStreamException), ClientCnxn(1161) will log such as the formart "Session 0x for server null, unexpected error, closing socket connection and attempting reconnect ". The log at line 1161 in zookeeper-3.3.3
>    We found that, zookeeper use "((SocketChannel)sockKey.channel()).socket().getRemoteSocketAddress()" to get zookeeper addr. But,Sometimes, it logs "Session 0x for server null", you know, if log null, developer can't determine the current zookeeper addr that client is connected or connecting.
>    I add a method in Class SendThread:InetSocketAddress org.apache.zookeeper.ClientCnxn.SendThread.getCurrentZooKeeperAddr().

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (ZOOKEEPER-1480) ClientCnxn(1161) can't get the current zk server add, so that - Session 0x for server null, unexpected error

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/ZOOKEEPER-1480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13290762#comment-13290762 ] 

Hadoop QA commented on ZOOKEEPER-1480:
--------------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12531207/getCurrentZooKeeperAddr_for_trunk.patch
  against trunk revision 1337029.

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1089//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1089//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1089//console

This message is automatically generated.
                
> ClientCnxn(1161) can't get the current zk server add, so that - Session 0x for server null, unexpected error
> ------------------------------------------------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-1480
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1480
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: java client
>    Affects Versions: 3.3.3
>            Reporter: Leader Ni
>            Assignee: Leader Ni
>              Labels: client, getCurrentZooKeeperAddr
>             Fix For: 3.4.4, 3.5.0
>
>         Attachments: getCurrentZooKeeperAddr_for_3.3.3.patch, getCurrentZooKeeperAddr_for_branch3.4.patch, getCurrentZooKeeperAddr_for_trunk.patch
>
>
>    When zookeeper occur an unexpected error( Not SessionExpiredException, SessionTimeoutException and EndOfStreamException), ClientCnxn(1161) will log such as the formart "Session 0x for server null, unexpected error, closing socket connection and attempting reconnect ". The log at line 1161 in zookeeper-3.3.3
>    We found that, zookeeper use "((SocketChannel)sockKey.channel()).socket().getRemoteSocketAddress()" to get zookeeper addr. But,Sometimes, it logs "Session 0x for server null", you know, if log null, developer can't determine the current zookeeper addr that client is connected or connecting.
>    I add a method in Class SendThread:InetSocketAddress org.apache.zookeeper.ClientCnxn.SendThread.getCurrentZooKeeperAddr().

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (ZOOKEEPER-1480) ClientCnxn(1161) can't get the current zk server add, so that - Session 0x for server null, unexpected error

Posted by "Leader Ni (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/ZOOKEEPER-1480?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Leader Ni updated ZOOKEEPER-1480:
---------------------------------

    Attachment:     (was: getCurrentZooKeeperAddr_for_3.3.3.patch)
    
> ClientCnxn(1161) can't get the current zk server add, so that - Session 0x for server null, unexpected error
> ------------------------------------------------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-1480
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1480
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: java client
>    Affects Versions: 3.3.3
>            Reporter: Leader Ni
>            Assignee: Leader Ni
>              Labels: client, getCurrentZooKeeperAddr
>             Fix For: 3.4.4, 3.5.0
>
>         Attachments: getCurrentZooKeeperAddr_for_branch3.4.patch
>
>
>    When zookeeper occur an unexpected error( Not SessionExpiredException, SessionTimeoutException and EndOfStreamException), ClientCnxn(1161) will log such as the formart "Session 0x for server null, unexpected error, closing socket connection and attempting reconnect ". The log at line 1161 in zookeeper-3.3.3
>    We found that, zookeeper use "((SocketChannel)sockKey.channel()).socket().getRemoteSocketAddress()" to get zookeeper addr. But,Sometimes, it logs "Session 0x for server null", you know, if log null, developer can't determine the current zookeeper addr that client is connected or connecting.
>    I add a method in Class SendThread:InetSocketAddress org.apache.zookeeper.ClientCnxn.SendThread.getCurrentZooKeeperAddr().

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (ZOOKEEPER-1480) ClientCnxn(1161) can't get the current zk server add, so that - Session 0x for server null, unexpected error

Posted by "Leader Ni (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/ZOOKEEPER-1480?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Leader Ni updated ZOOKEEPER-1480:
---------------------------------

    Attachment: getCurrentZooKeeperAddr_for_3.4.3.patch
    
> ClientCnxn(1161) can't get the current zk server add, so that - Session 0x for server null, unexpected error
> ------------------------------------------------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-1480
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1480
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: java client
>    Affects Versions: 3.4.3
>            Reporter: Leader Ni
>            Assignee: Leader Ni
>              Labels: client, getCurrentZooKeeperAddr
>             Fix For: 3.5.0
>
>         Attachments: getCurrentZooKeeperAddr_for_3.4.3.patch, getCurrentZooKeeperAddr_for_branch3.4.patch
>
>
>    When zookeeper occur an unexpected error( Not SessionExpiredException, SessionTimeoutException and EndOfStreamException), ClientCnxn(1161) will log such as the formart "Session 0x for server null, unexpected error, closing socket connection and attempting reconnect ". The log at line 1161 in zookeeper-3.3.3
>    We found that, zookeeper use "((SocketChannel)sockKey.channel()).socket().getRemoteSocketAddress()" to get zookeeper addr. But,Sometimes, it logs "Session 0x for server null", you know, if log null, developer can't determine the current zookeeper addr that client is connected or connecting.
>    I add a method in Class SendThread:InetSocketAddress org.apache.zookeeper.ClientCnxn.SendThread.getCurrentZooKeeperAddr().

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (ZOOKEEPER-1480) ClientCnxn(1161) can't get the current zk server add, so that - Session 0x for server null, unexpected error

Posted by "Leader Ni (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/ZOOKEEPER-1480?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Leader Ni updated ZOOKEEPER-1480:
---------------------------------

    Attachment:     (was: getCurrentZooKeeperAddr_for_trunk.patch)
    
> ClientCnxn(1161) can't get the current zk server add, so that - Session 0x for server null, unexpected error
> ------------------------------------------------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-1480
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1480
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: java client
>    Affects Versions: 3.3.3
>            Reporter: Leader Ni
>            Assignee: Leader Ni
>              Labels: client, getCurrentZooKeeperAddr
>             Fix For: 3.4.4, 3.5.0
>
>         Attachments: getCurrentZooKeeperAddr_for_branch3.4.patch
>
>
>    When zookeeper occur an unexpected error( Not SessionExpiredException, SessionTimeoutException and EndOfStreamException), ClientCnxn(1161) will log such as the formart "Session 0x for server null, unexpected error, closing socket connection and attempting reconnect ". The log at line 1161 in zookeeper-3.3.3
>    We found that, zookeeper use "((SocketChannel)sockKey.channel()).socket().getRemoteSocketAddress()" to get zookeeper addr. But,Sometimes, it logs "Session 0x for server null", you know, if log null, developer can't determine the current zookeeper addr that client is connected or connecting.
>    I add a method in Class SendThread:InetSocketAddress org.apache.zookeeper.ClientCnxn.SendThread.getCurrentZooKeeperAddr().

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (ZOOKEEPER-1480) ClientCnxn(1161) can't get the current zk server add, so that - Session 0x for server null, unexpected error

Posted by "Leader Ni (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/ZOOKEEPER-1480?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Leader Ni updated ZOOKEEPER-1480:
---------------------------------

    Attachment:     (was: getCurrentZooKeeperAddr.patch)
    
> ClientCnxn(1161) can't get the current zk server add, so that - Session 0x for server null, unexpected error
> ------------------------------------------------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-1480
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1480
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: java client
>    Affects Versions: 3.3.3
>            Reporter: Leader Ni
>            Assignee: Leader Ni
>              Labels: client, getCurrentZooKeeperAddr
>             Fix For: 3.4.4, 3.5.0
>
>         Attachments: getCurrentZooKeeperAddr_for_3.3.3.patch, getCurrentZooKeeperAddr_for_branch3.4.patch, getCurrentZooKeeperAddr_for_trunk.patch
>
>
>    When zookeeper occur an unexpected error( Not SessionExpiredException, SessionTimeoutException and EndOfStreamException), ClientCnxn(1161) will log such as the formart "Session 0x for server null, unexpected error, closing socket connection and attempting reconnect ". The log at line 1161 in zookeeper-3.3.3
>    We found that, zookeeper use "((SocketChannel)sockKey.channel()).socket().getRemoteSocketAddress()" to get zookeeper addr. But,Sometimes, it logs "Session 0x for server null", you know, if log null, developer can't determine the current zookeeper addr that client is connected or connecting.
>    I add a method in Class SendThread:InetSocketAddress org.apache.zookeeper.ClientCnxn.SendThread.getCurrentZooKeeperAddr().

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (ZOOKEEPER-1480) ClientCnxn(1161) can't get the current zk server add, so that - Session 0x for server null, unexpected error

Posted by "Leader Ni (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/ZOOKEEPER-1480?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Leader Ni updated ZOOKEEPER-1480:
---------------------------------

    Description: 
  When zookeeper occur an unexpected error( Not SessionExpiredException, SessionTimeoutException and EndOfStreamException), ClientCnxn(1161) will log such as the formart "Session 0x for server null, unexpected error, closing socket connection and attempting reconnect ". The log at line 1161 in zookeeper-3.3.3
  We found that, zookeeper use "((SocketChannel)sockKey.channel()).socket().getRemoteSocketAddress()" to get zookeeper addr. But,Sometimes, it logs "Session 0x for server null", you know, if log null, developer can't determine the current zookeeper addr that client is connected or connecting.
  I add a method in Class SendThread:InetSocketAddress org.apache.zookeeper.ClientCnxn.SendThread.getCurrentZooKeeperAddr().

  Here:
/**
* Returns the address to which the socket is connected.
* 
* @return ip address of the remote side of the connection or null if not
*         connected
*/
@Override
SocketAddress getRemoteSocketAddress() {
   // a lot could go wrong here, so rather than put in a bunch of code
   // to check for nulls all down the chain let's do it the simple
   // yet bulletproof way 
.....


  was:
  When zookeeper occur an unexpected error( Not SessionExpiredException, SessionTimeoutException and EndOfStreamException), ClientCnxn(1161) will log such as the formart "Session 0x for server null, unexpected error, closing socket connection and attempting reconnect ". The log at line 1161 in zookeeper-3.3.3
  We found that, zookeeper use "((SocketChannel)sockKey.channel()).socket().getRemoteSocketAddress()" to get zookeeper addr. But,Sometimes, it logs "Session 0x for server null", you know, if log null, developer can't determine the current zookeeper addr that client is connected or connecting.
  I add a method in Class SendThread:InetSocketAddress org.apache.zookeeper.ClientCnxn.SendThread.getCurrentZooKeeperAddr().

  Here:
/**
     * Returns the address to which the socket is connected.
     * 
     * @return ip address of the remote side of the connection or null if not
     *         connected
     */
    @Override
    SocketAddress getRemoteSocketAddress() {
        // a lot could go wrong here, so rather than put in a bunch of code
        // to check for nulls all down the chain let's do it the simple
        // yet bulletproof way
        try {
            return ((SocketChannel) sockKey.channel()).socket()
                    .getRemoteSocketAddress();
        } catch (NullPointerException e) {
            return null;
        }
    }


    
> ClientCnxn(1161) can't get the current zk server add, so that - Session 0x for server null, unexpected error
> ------------------------------------------------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-1480
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1480
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: java client
>    Affects Versions: 3.4.3
>            Reporter: Leader Ni
>            Assignee: Leader Ni
>              Labels: client, getCurrentZooKeeperAddr
>             Fix For: 3.5.0
>
>         Attachments: getCurrentZooKeeperAddr_for_3.4.3.patch, getCurrentZooKeeperAddr_for_branch3.4.patch
>
>
>   When zookeeper occur an unexpected error( Not SessionExpiredException, SessionTimeoutException and EndOfStreamException), ClientCnxn(1161) will log such as the formart "Session 0x for server null, unexpected error, closing socket connection and attempting reconnect ". The log at line 1161 in zookeeper-3.3.3
>   We found that, zookeeper use "((SocketChannel)sockKey.channel()).socket().getRemoteSocketAddress()" to get zookeeper addr. But,Sometimes, it logs "Session 0x for server null", you know, if log null, developer can't determine the current zookeeper addr that client is connected or connecting.
>   I add a method in Class SendThread:InetSocketAddress org.apache.zookeeper.ClientCnxn.SendThread.getCurrentZooKeeperAddr().
>   Here:
> /**
> * Returns the address to which the socket is connected.
> * 
> * @return ip address of the remote side of the connection or null if not
> *         connected
> */
> @Override
> SocketAddress getRemoteSocketAddress() {
>    // a lot could go wrong here, so rather than put in a bunch of code
>    // to check for nulls all down the chain let's do it the simple
>    // yet bulletproof way 
> .....

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (ZOOKEEPER-1480) ClientCnxn(1161) can't get the current zk server add, so that - Session 0x for server null, unexpected error

Posted by "Leader Ni (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/ZOOKEEPER-1480?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Leader Ni updated ZOOKEEPER-1480:
---------------------------------

    Description: 
  When zookeeper occur an unexpected error( Not SessionExpiredException, SessionTimeoutException and EndOfStreamException), ClientCnxn(1161) will log such as the formart "Session 0x for server null, unexpected error, closing socket connection and attempting reconnect ". The log at line 1161 in zookeeper-3.3.3
  We found that, zookeeper use "((SocketChannel)sockKey.channel()).socket().getRemoteSocketAddress()" to get zookeeper addr. But,Sometimes, it logs "Session 0x for server null", you know, if log null, developer can't determine the current zookeeper addr that client is connected or connecting.
  I add a method in Class SendThread:InetSocketAddress org.apache.zookeeper.ClientCnxn.SendThread.getCurrentZooKeeperAddr().

  Here:
/**
     * Returns the address to which the socket is connected.
     * 
     * @return ip address of the remote side of the connection or null if not
     *         connected
     */
    @Override
    SocketAddress getRemoteSocketAddress() {
        // a lot could go wrong here, so rather than put in a bunch of code
        // to check for nulls all down the chain let's do it the simple
        // yet bulletproof way
        try {
            return ((SocketChannel) sockKey.channel()).socket()
                    .getRemoteSocketAddress();
        } catch (NullPointerException e) {
            return null;
        }
    }


  was:
   When zookeeper occur an unexpected error( Not SessionExpiredException, SessionTimeoutException and EndOfStreamException), ClientCnxn(1161) will log such as the formart "Session 0x for server null, unexpected error, closing socket connection and attempting reconnect ". The log at line 1161 in zookeeper-3.3.3
   We found that, zookeeper use "((SocketChannel)sockKey.channel()).socket().getRemoteSocketAddress()" to get zookeeper addr. But,Sometimes, it logs "Session 0x for server null", you know, if log null, developer can't determine the current zookeeper addr that client is connected or connecting.
   I add a method in Class SendThread:InetSocketAddress org.apache.zookeeper.ClientCnxn.SendThread.getCurrentZooKeeperAddr().



    
> ClientCnxn(1161) can't get the current zk server add, so that - Session 0x for server null, unexpected error
> ------------------------------------------------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-1480
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1480
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: java client
>    Affects Versions: 3.4.3
>            Reporter: Leader Ni
>            Assignee: Leader Ni
>              Labels: client, getCurrentZooKeeperAddr
>             Fix For: 3.5.0
>
>         Attachments: getCurrentZooKeeperAddr_for_3.4.3.patch, getCurrentZooKeeperAddr_for_branch3.4.patch
>
>
>   When zookeeper occur an unexpected error( Not SessionExpiredException, SessionTimeoutException and EndOfStreamException), ClientCnxn(1161) will log such as the formart "Session 0x for server null, unexpected error, closing socket connection and attempting reconnect ". The log at line 1161 in zookeeper-3.3.3
>   We found that, zookeeper use "((SocketChannel)sockKey.channel()).socket().getRemoteSocketAddress()" to get zookeeper addr. But,Sometimes, it logs "Session 0x for server null", you know, if log null, developer can't determine the current zookeeper addr that client is connected or connecting.
>   I add a method in Class SendThread:InetSocketAddress org.apache.zookeeper.ClientCnxn.SendThread.getCurrentZooKeeperAddr().
>   Here:
> /**
>      * Returns the address to which the socket is connected.
>      * 
>      * @return ip address of the remote side of the connection or null if not
>      *         connected
>      */
>     @Override
>     SocketAddress getRemoteSocketAddress() {
>         // a lot could go wrong here, so rather than put in a bunch of code
>         // to check for nulls all down the chain let's do it the simple
>         // yet bulletproof way
>         try {
>             return ((SocketChannel) sockKey.channel()).socket()
>                     .getRemoteSocketAddress();
>         } catch (NullPointerException e) {
>             return null;
>         }
>     }

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (ZOOKEEPER-1480) ClientCnxn(1161) can't get the current zk server add, so that - Session 0x for server null, unexpected error

Posted by "Leader Ni (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/ZOOKEEPER-1480?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Leader Ni updated ZOOKEEPER-1480:
---------------------------------

    Attachment: getCurrentZooKeeperAddr.patch
    
> ClientCnxn(1161) can't get the current zk server add, so that - Session 0x for server null, unexpected error
> ------------------------------------------------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-1480
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1480
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: java client
>    Affects Versions: 3.3.3
>            Reporter: Leader Ni
>            Assignee: Leader Ni
>              Labels: client, getCurrentZooKeeperAddr
>             Fix For: 3.3.6
>
>         Attachments: getCurrentZooKeeperAddr.patch
>
>
>    When zookeeper occur an unexpected error( Not SessionExpiredException, SessionTimeoutException and EndOfStreamException), ClientCnxn(1161) will log such as the formart "Session 0x for server null, unexpected error, closing socket connection and attempting reconnect ". The log at line 1161 in zookeeper-3.3.3
>    We found that, zookeeper use "((SocketChannel)sockKey.channel()).socket().getRemoteSocketAddress()" to get zookeeper addr. But,Sometimes, it logs "Session 0x for server null", you know, if log null, developer can't determine the current zookeeper addr that client is connected or connecting.
>    I add a method in Class SendThread:InetSocketAddress org.apache.zookeeper.ClientCnxn.SendThread.getCurrentZooKeeperAddr().

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (ZOOKEEPER-1480) ClientCnxn(1161) can't get the current zk server add, so that - Session 0x for server null, unexpected error

Posted by "Leader Ni (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/ZOOKEEPER-1480?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Leader Ni updated ZOOKEEPER-1480:
---------------------------------

    Attachment: getCurrentZooKeeperAddr.path
    
> ClientCnxn(1161) can't get the current zk server add, so that - Session 0x for server null, unexpected error
> ------------------------------------------------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-1480
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1480
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: java client
>    Affects Versions: 3.3.3
>            Reporter: Leader Ni
>            Assignee: Leader Ni
>              Labels: client, getCurrentZooKeeperAddr
>             Fix For: 3.3.6
>
>         Attachments: getCurrentZooKeeperAddr.path
>
>
>    When zookeeper occur an unexpected error( Not SessionExpiredException, SessionTimeoutException and EndOfStreamException), ClientCnxn(1161) will log such as the formart "Session 0x for server null, unexpected error, closing socket connection and attempting reconnect ". The log at line 1161 in zookeeper-3.3.3
>    We found that, zookeeper use "((SocketChannel)sockKey.channel()).socket().getRemoteSocketAddress()" to get zookeeper addr. But,Sometimes, it logs "Session 0x for server null", you know, if log null, developer can't determine the current zookeeper addr that client is connected or connecting.
>    I add a method in Class SendThread:InetSocketAddress org.apache.zookeeper.ClientCnxn.SendThread.getCurrentZooKeeperAddr().

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (ZOOKEEPER-1480) ClientCnxn(1161) can't get the current zk server add, so that - Session 0x for server null, unexpected error

Posted by "Leader Ni (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/ZOOKEEPER-1480?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Leader Ni updated ZOOKEEPER-1480:
---------------------------------

    Attachment:     (was: getCurrentZooKeeperAddr.path)
    
> ClientCnxn(1161) can't get the current zk server add, so that - Session 0x for server null, unexpected error
> ------------------------------------------------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-1480
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1480
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: java client
>    Affects Versions: 3.3.3
>            Reporter: Leader Ni
>            Assignee: Leader Ni
>              Labels: client, getCurrentZooKeeperAddr
>             Fix For: 3.3.6
>
>         Attachments: getCurrentZooKeeperAddr.patch
>
>
>    When zookeeper occur an unexpected error( Not SessionExpiredException, SessionTimeoutException and EndOfStreamException), ClientCnxn(1161) will log such as the formart "Session 0x for server null, unexpected error, closing socket connection and attempting reconnect ". The log at line 1161 in zookeeper-3.3.3
>    We found that, zookeeper use "((SocketChannel)sockKey.channel()).socket().getRemoteSocketAddress()" to get zookeeper addr. But,Sometimes, it logs "Session 0x for server null", you know, if log null, developer can't determine the current zookeeper addr that client is connected or connecting.
>    I add a method in Class SendThread:InetSocketAddress org.apache.zookeeper.ClientCnxn.SendThread.getCurrentZooKeeperAddr().

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (ZOOKEEPER-1480) ClientCnxn(1161) can't get the current zk server add, so that - Session 0x for server null, unexpected error

Posted by "Leader Ni (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/ZOOKEEPER-1480?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Leader Ni updated ZOOKEEPER-1480:
---------------------------------

    Attachment: getCurrentZooKeeperAddr_for_trunk.patch
                getCurrentZooKeeperAddr_for_branch3.4.patch
                getCurrentZooKeeperAddr_for_3.3.3.patch
    
> ClientCnxn(1161) can't get the current zk server add, so that - Session 0x for server null, unexpected error
> ------------------------------------------------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-1480
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1480
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: java client
>    Affects Versions: 3.3.3
>            Reporter: Leader Ni
>            Assignee: Leader Ni
>              Labels: client, getCurrentZooKeeperAddr
>             Fix For: 3.4.4, 3.5.0
>
>         Attachments: getCurrentZooKeeperAddr.patch, getCurrentZooKeeperAddr_for_3.3.3.patch, getCurrentZooKeeperAddr_for_branch3.4.patch, getCurrentZooKeeperAddr_for_trunk.patch
>
>
>    When zookeeper occur an unexpected error( Not SessionExpiredException, SessionTimeoutException and EndOfStreamException), ClientCnxn(1161) will log such as the formart "Session 0x for server null, unexpected error, closing socket connection and attempting reconnect ". The log at line 1161 in zookeeper-3.3.3
>    We found that, zookeeper use "((SocketChannel)sockKey.channel()).socket().getRemoteSocketAddress()" to get zookeeper addr. But,Sometimes, it logs "Session 0x for server null", you know, if log null, developer can't determine the current zookeeper addr that client is connected or connecting.
>    I add a method in Class SendThread:InetSocketAddress org.apache.zookeeper.ClientCnxn.SendThread.getCurrentZooKeeperAddr().

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (ZOOKEEPER-1480) ClientCnxn(1161) can't get the current zk server add, so that - Session 0x for server null, unexpected error

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/ZOOKEEPER-1480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13289899#comment-13289899 ] 

Hadoop QA commented on ZOOKEEPER-1480:
--------------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12531055/getCurrentZooKeeperAddr.patch
  against trunk revision 1337029.

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    -1 patch.  The patch command could not apply the patch.

Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1087//console

This message is automatically generated.
                
> ClientCnxn(1161) can't get the current zk server add, so that - Session 0x for server null, unexpected error
> ------------------------------------------------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-1480
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1480
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: java client
>    Affects Versions: 3.3.3
>            Reporter: Leader Ni
>            Assignee: Leader Ni
>              Labels: client, getCurrentZooKeeperAddr
>             Fix For: 3.3.6
>
>         Attachments: getCurrentZooKeeperAddr.patch
>
>
>    When zookeeper occur an unexpected error( Not SessionExpiredException, SessionTimeoutException and EndOfStreamException), ClientCnxn(1161) will log such as the formart "Session 0x for server null, unexpected error, closing socket connection and attempting reconnect ". The log at line 1161 in zookeeper-3.3.3
>    We found that, zookeeper use "((SocketChannel)sockKey.channel()).socket().getRemoteSocketAddress()" to get zookeeper addr. But,Sometimes, it logs "Session 0x for server null", you know, if log null, developer can't determine the current zookeeper addr that client is connected or connecting.
>    I add a method in Class SendThread:InetSocketAddress org.apache.zookeeper.ClientCnxn.SendThread.getCurrentZooKeeperAddr().

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (ZOOKEEPER-1480) ClientCnxn(1161) can't get the current zk server add, so that - Session 0x for server null, unexpected error

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/ZOOKEEPER-1480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13490296#comment-13490296 ] 

Hadoop QA commented on ZOOKEEPER-1480:
--------------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12552006/getCurrentZooKeeperAddr_for_3.4.3.patch
  against trunk revision 1404288.

    -1 @author.  The patch appears to contain 1 @author tags which the Zookeeper community has agreed to not allow in code contributions.

    +1 tests included.  The patch appears to include 3 new or modified tests.

    -1 patch.  The patch command could not apply the patch.

Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1247//console

This message is automatically generated.
                
> ClientCnxn(1161) can't get the current zk server add, so that - Session 0x for server null, unexpected error
> ------------------------------------------------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-1480
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1480
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: java client
>    Affects Versions: 3.4.3
>            Reporter: Leader Ni
>            Assignee: Leader Ni
>              Labels: client, getCurrentZooKeeperAddr
>             Fix For: 3.5.0
>
>         Attachments: getCurrentZooKeeperAddr_for_3.4.3.patch, getCurrentZooKeeperAddr_for_branch3.4.patch
>
>
>   When zookeeper occur an unexpected error( Not SessionExpiredException, SessionTimeoutException and EndOfStreamException), ClientCnxn(1161) will log such as the formart "Session 0x for server null, unexpected error, closing socket connection and attempting reconnect ". The log at line 1161 in zookeeper-3.3.3
>   We found that, zookeeper use "((SocketChannel)sockKey.channel()).socket().getRemoteSocketAddress()" to get zookeeper addr. But,Sometimes, it logs "Session 0x for server null", you know, if log null, developer can't determine the current zookeeper addr that client is connected or connecting.
>   I add a method in Class SendThread:InetSocketAddress org.apache.zookeeper.ClientCnxn.SendThread.getCurrentZooKeeperAddr().
>   Here:
> /**
> * Returns the address to which the socket is connected.
> * 
> * @return ip address of the remote side of the connection or null if not
> *         connected
> */
> @Override
> SocketAddress getRemoteSocketAddress() {
>    // a lot could go wrong here, so rather than put in a bunch of code
>    // to check for nulls all down the chain let's do it the simple
>    // yet bulletproof way 
> .....

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (ZOOKEEPER-1480) ClientCnxn(1161) can't get the current zk server add, so that - Session 0x for server null, unexpected error

Posted by "Leader Ni (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/ZOOKEEPER-1480?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Leader Ni updated ZOOKEEPER-1480:
---------------------------------

    Description: 
   When zookeeper occur an unexpected error( Not SessionExpiredException, SessionTimeoutException and EndOfStreamException), ClientCnxn(1161) will log such as the formart "Session 0x for server null, unexpected error, closing socket connection and attempting reconnect ". The log at line 1161 in zookeeper-3.3.3
   We found that, zookeeper use "((SocketChannel)sockKey.channel()).socket().getRemoteSocketAddress()" to get zookeeper addr. But,Sometimes, it logs "Session 0x for server null", you know, if log null, developer can't determine the current zookeeper addr that client is connected or connecting.
   I add a method in Class SendThread:InetSocketAddress org.apache.zookeeper.ClientCnxn.SendThread.getCurrentZooKeeperAddr().



  was:
   When zookeeper occur an unexpected error( Not SessionExpiredException, SessionTimeoutException and EndOfStreamException), ClientCnxn(1161) will log such as the formart "Session 0x for server null, unexpected error, closing socket connection and attempting reconnect ". The log at line 1161 in zookeeper-3.3.3
   We found that, sometimes, it logs "Session 0x for server null", you know, if log null, developer can't determine the current zookeeper addr that client is connected or connecting.
   I add a method in Class SendThread:InetSocketAddress org.apache.zookeeper.ClientCnxn.SendThread.getCurrentZooKeeperAddr().



    
> ClientCnxn(1161) can't get the current zk server add, so that - Session 0x for server null, unexpected error
> ------------------------------------------------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-1480
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1480
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: java client
>    Affects Versions: 3.3.3
>            Reporter: Leader Ni
>            Assignee: Leader Ni
>              Labels: client, getCurrentZooKeeperAddr
>             Fix For: 3.3.6
>
>
>    When zookeeper occur an unexpected error( Not SessionExpiredException, SessionTimeoutException and EndOfStreamException), ClientCnxn(1161) will log such as the formart "Session 0x for server null, unexpected error, closing socket connection and attempting reconnect ". The log at line 1161 in zookeeper-3.3.3
>    We found that, zookeeper use "((SocketChannel)sockKey.channel()).socket().getRemoteSocketAddress()" to get zookeeper addr. But,Sometimes, it logs "Session 0x for server null", you know, if log null, developer can't determine the current zookeeper addr that client is connected or connecting.
>    I add a method in Class SendThread:InetSocketAddress org.apache.zookeeper.ClientCnxn.SendThread.getCurrentZooKeeperAddr().

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira