[GitHub] [pinot] klsince commented on a diff in pull request #9306: TierBasedSegmentDirectoryLoader to keep segments in multi-datadir

[GitBox <gi...@apache.org>]

klsince commented on code in PR #9306:
URL: https://github.com/apache/pinot/pull/9306#discussion_r994953011


##########
pinot-core/src/main/java/org/apache/pinot/core/data/manager/BaseTableDataManager.java:
##########
@@ -329,7 +330,8 @@ public Map<String, SegmentErrorInfo> getSegmentErrors() {
   public void reloadSegment(String segmentName, IndexLoadingConfig indexLoadingConfig, SegmentZKMetadata zkMetadata,
       SegmentMetadata localMetadata, @Nullable Schema schema, boolean forceDownload)
       throws Exception {
-    File indexDir = getSegmentDataDir(segmentName);
+    String segmentTier = getSegmentCurrentTier(segmentName);

Review Comment:
   I'll refactor this in a separate PR, as it's orthogonal to the feature of this PR.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org