[GitHub] [spark] attilapiros edited a comment on pull request #31719: [SPARK-34361][K8S][FOLLOWUP] Fix potentially flaky unit test with multiple resource profiles in ExecutorPodsAllocatorSuite

[GitBox <gi...@apache.org>]

attilapiros edited a comment on pull request #31719:
URL: https://github.com/apache/spark/pull/31719#issuecomment-789602302


   I wanted to be 100% sure that there is no more flakiness in the test. So temporary I have done a small code change and the sorted the map to test both asc and desc ordering. With this temporary code I have found a bug in an earlier test (in `SPARK-33288: multiple resource profiles`) which was there even before my SPARK-34361 PR.
   
   So to be on the safe side I decided to modify the production code to have a deterministic ordering for allocating the resources( in case of multiple resource profiles).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org