You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@kafka.apache.org by "Swapnil Ghike (JIRA)" <ji...@apache.org> on 2013/03/07 19:24:12 UTC

[jira] [Commented] (KAFKA-794) Clean up controller logging

    [ https://issues.apache.org/jira/browse/KAFKA-794?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13596142#comment-13596142 ] 

Swapnil Ghike commented on KAFKA-794:
-------------------------------------

This should wait till KAFKA-793 is checked in.
                
> Clean up controller logging
> ---------------------------
>
>                 Key: KAFKA-794
>                 URL: https://issues.apache.org/jira/browse/KAFKA-794
>             Project: Kafka
>          Issue Type: Improvement
>          Components: controller
>    Affects Versions: 0.8
>            Reporter: Neha Narkhede
>            Assignee: Neha Narkhede
>            Priority: Blocker
>              Labels: kafka-0.8, p2
>
> We created the state change log in KAFKA-513 which creates a well formatted log of the lifetime of all state change requests in a Kafka cluster. While troubleshooting KAFKA-790, I looked into server.log, controller.log and state-change.log and realized we can improve the controller logging -
> 1. StopReplica state change is missing from the state-change.log
> 2. Some state change log messages are repeated. These are likely mistakenly inside a for loop rather than outside
> 3. Some controller logging that should be in the controller.log is still in server.log. For example, everything from ReplicaManager. This is useful for troubleshooting but confusing to be inside server.log.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira