You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2022/11/19 02:37:02 UTC

[GitHub] [druid] cryptoe commented on pull request #13374: Migrate current integration batch tests to equivalent MSQ tests

cryptoe commented on PR #13374:
URL: https://github.com/apache/druid/pull/13374#issuecomment-1320760129

   Another nit we should fix in this PR : 
   ```
   2022-11-18T19:26:19,074 INFO [main] org.apache.druid.testing.utils.TestQueryHelper - Sql Task submitted with task Id - query-77b14a7e-999d-4756-92eb-9fba59f68836
   
   2022-11-18T19:26:19,105 WARN [main] org.apache.druid.java.util.common.RetryUtils - Retrying (1 of 99) in 895ms.
   
   org.apache.druid.testing.utils.MsqTestQueryHelper$TaskStillRunningException: null
   
   	at org.apache.druid.testing.utils.MsqTestQueryHelper.lambda$pollTaskIdForCompletion$0(MsqTestQueryHelper.java:163) ~[druid-integration-tests-25.0.0-SNAPSHOT.jar:25.0.0-SNAPSHOT]
   
   	at org.apache.druid.java.util.common.RetryUtils.retry(RetryUtils.java:129) ~[druid-core-25.0.0-SNAPSHOT.jar:25.0.0-SNAPSHOT]
   
   	at org.apache.druid.java.util.common.RetryUtils.retry(RetryUtils.java:81) ~[druid-core-25.0.0-SNAPSHOT.jar:25.0.0-SNAPSHOT]
   
   	at org.apache.druid.java.util.common.RetryUtils.retry(RetryUtils.java:163) ~[druid-core-25.0.0-SNAPSHOT.jar:25.0.0-SNAPSHOT]
   
   	at org.apache.druid.java.util.common.RetryUtils.retry(RetryUtils.java:153) ~[druid-core-25.0.0-SNAPSHOT.jar:25.0.0-SNAPSHOT]
   	
   	```
   	
   	```
   	public TaskState pollTaskIdForCompletion(String taskId) throws Exception
     {
       return RetryUtils.retry(
           () -> {
             TaskStatusPlus taskStatusPlus = overlordClient.getTaskStatus(taskId);
             TaskState statusCode = taskStatusPlus.getStatusCode();
             if (statusCode != null && statusCode.isComplete()) {
               return taskStatusPlus.getStatusCode();
             }
             throw new TaskStillRunningException();
           },
           (Throwable t) -> t instanceof TaskStillRunningException,
           100
       );
     }
     ```
   	let's change this method to not throw an exception but just log unable to get the status of the task.
   	
   	


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org