You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eventmesh.apache.org by GitBox <gi...@apache.org> on 2023/01/08 05:17:32 UTC
[GitHub] [incubator-eventmesh] wqliang opened a new pull request, #2856: [ISSUE #285] add SubscriptionManager
wqliang opened a new pull request, #2856:
URL: https://github.com/apache/incubator-eventmesh/pull/2856
Fixes #2852 .
### Motivation
- add `SubscriptionManager` to manage client info adn sub topics;
- reduce redundant code for updating client info and sub topics info;
### Modifications
- add `SubscriptionManager` and move 'localConsumerGroupMapping' 'localClientInfoMapping' from `EventMeshHTTPServer` to `SubscriptionManager`;
- use `SubscriptionManager` to registerClient on `SubscribeProcessor`;
- use `SubscriptionManager` to registerClient on `LocalSubscribeEventProcessor`;
- use `SubscriptionManager` to update sub topics on `SubscribeProcessor`;
- use `SubscriptionManager` to update sub topics on `LocalSubscribeEventProcessor`;
### Documentation
- Does this pull request introduce a new feature? (no)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] codecov[bot] commented on pull request #2856: [ISSUE #285] add SubscriptionManager
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #2856:
URL: https://github.com/apache/incubator-eventmesh/pull/2856#issuecomment-1374878115
# [Codecov](https://codecov.io/gh/apache/incubator-eventmesh/pull/2856?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#2856](https://codecov.io/gh/apache/incubator-eventmesh/pull/2856?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f153882) into [master](https://codecov.io/gh/apache/incubator-eventmesh/commit/3bda8fbe10e0710c2ab8ae720cfa6cbaebeac249?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3bda8fb) will **increase** coverage by `0.02%`.
> The diff coverage is `0.00%`.
```diff
@@ Coverage Diff @@
## master #2856 +/- ##
============================================
+ Coverage 11.61% 11.64% +0.02%
Complexity 911 911
============================================
Files 503 505 +2
Lines 28093 28023 -70
Branches 2876 2847 -29
============================================
Hits 3264 3264
+ Misses 24533 24465 -68
+ Partials 296 294 -2
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-eventmesh/pull/2856?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...tmesh/runtime/admin/handler/HTTPClientHandler.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/2856?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2FkbWluL2hhbmRsZXIvSFRUUENsaWVudEhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...he/eventmesh/runtime/boot/EventMeshHTTPServer.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/2856?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2Jvb3QvRXZlbnRNZXNoSFRUUFNlcnZlci5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...che/eventmesh/runtime/boot/EventMeshTCPServer.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/2856?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2Jvb3QvRXZlbnRNZXNoVENQU2VydmVyLmphdmE=) | `0.57% <ø> (+<0.01%)` | :arrow_up: |
| [...he/eventmesh/runtime/core/consumer/ClientInfo.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/2856?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2NvcmUvY29uc3VtZXIvQ2xpZW50SW5mby5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...esh/runtime/core/consumer/SubscriptionManager.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/2856?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2NvcmUvY29uc3VtZXIvU3Vic2NyaXB0aW9uTWFuYWdlci5qYXZh) | `0.00% <0.00%> (ø)` | |
| [.../runtime/core/consumergroup/ConsumerGroupConf.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/2856?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2NvcmUvY29uc3VtZXJncm91cC9Db25zdW1lckdyb3VwQ29uZi5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...protocol/http/consumer/HttpClientGroupMapping.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/2856?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2NvcmUvcHJvdG9jb2wvaHR0cC9jb25zdW1lci9IdHRwQ2xpZW50R3JvdXBNYXBwaW5nLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...re/protocol/http/processor/HeartBeatProcessor.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/2856?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2NvcmUvcHJvdG9jb2wvaHR0cC9wcm9jZXNzb3IvSGVhcnRCZWF0UHJvY2Vzc29yLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...l/http/processor/LocalSubscribeEventProcessor.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/2856?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2NvcmUvcHJvdG9jb2wvaHR0cC9wcm9jZXNzb3IvTG9jYWxTdWJzY3JpYmVFdmVudFByb2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...http/processor/LocalUnSubscribeEventProcessor.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/2856?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2NvcmUvcHJvdG9jb2wvaHR0cC9wcm9jZXNzb3IvTG9jYWxVblN1YnNjcmliZUV2ZW50UHJvY2Vzc29yLmphdmE=) | `0.00% <0.00%> (ø)` | |
| ... and [14 more](https://codecov.io/gh/apache/incubator-eventmesh/pull/2856?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] jonyangx merged pull request #2856: [ISSUE #285] add SubscriptionManager
Posted by GitBox <gi...@apache.org>.
jonyangx merged PR #2856:
URL: https://github.com/apache/incubator-eventmesh/pull/2856
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org