You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/10/15 03:02:31 UTC

[GitHub] [doris] etcZYP opened a new pull request, #13387: [Enhancement] replace assertTrue(X.equals(X)) with assertEquals

etcZYP opened a new pull request, #13387:
URL: https://github.com/apache/doris/pull/13387

   # Proposed changes
   
   Issue Number: close https://github.com/apache/doris/issues/11916
   
   ## Problem summary
   
   replace assertTrue(X.equals(X)) with assertEquals.
   
   ## Checklist(Required)
   
   1. Does it affect the original behavior: 
       - [ ] Yes
       - [x] No
       - [ ] I don't know
   2. Has unit tests been added:
       - [ ] Yes
       - [x] No
       - [ ] No Need
   3. Has document been added or modified:
       - [ ] Yes
       - [x] No
       - [ ] No Need
   4. Does it need to update dependencies:
       - [ ] Yes
       - [x] No
   5. Are there any changes that cannot be rolled back:
       - [ ] Yes (If Yes, please explain WHY)
       - [x] No
   
   ## Further comments
   
   If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] etcZYP closed pull request #13387: [Enhancement] replace assertTrue(X.equals(X)) with assertEquals

Posted by GitBox <gi...@apache.org>.
etcZYP closed pull request #13387: [Enhancement] replace assertTrue(X.equals(X)) with assertEquals
URL: https://github.com/apache/doris/pull/13387


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] jackwener commented on pull request #13387: [Enhancement] replace assertTrue(X.equals(X)) with assertEquals

Posted by GitBox <gi...@apache.org>.
jackwener commented on PR #13387:
URL: https://github.com/apache/doris/pull/13387#issuecomment-1279720063

   I suggest the you can use `intellij IDEA` open project. And `IDEA` will suggest it and auto fix it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org