You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by iilyak <gi...@git.apache.org> on 2016/10/13 22:06:55 UTC
[GitHub] couchdb-couch pull request #206: 71810 handle errors terms from fabric
GitHub user iilyak opened a pull request:
https://github.com/apache/couchdb-couch/pull/206
71810 handle errors terms from fabric
Test suite for https://github.com/apache/couchdb-chttpd/pull/146
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cloudant/couchdb-couch 71810-handle-errors-terms-from-fabric
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/couchdb-couch/pull/206.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #206
----
commit 6b40de3c185dd8f56d193dc0b2f83e28841bb3ed
Author: Nick Vatamaniuc <va...@apache.org>
Date: 2016-10-10T05:47:49Z
Fix module name in couch_httpd:check_max_request_length/1 call
commit fb12795de011f8eb65a6f0a1ed67828486d21bb8
Author: Robert Newson <rn...@apache.org>
Date: 2016-10-12T20:54:00Z
whitespace change to trigger github mirror sync
commit e719f75d2791bd9c36db750e6968e10c3e329931
Author: ILYA Khlopotov <ii...@apache.org>
Date: 2016-10-13T21:56:19Z
Add test suite for handling errors from fabric
COUCHDB-3195
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-couch pull request #206: handle errors terms from fabric
Posted by jaydoane <gi...@git.apache.org>.
Github user jaydoane commented on a diff in the pull request:
https://github.com/apache/couchdb-couch/pull/206#discussion_r87302756
--- Diff: test/couchdb_mrview_tests.erl ---
@@ -73,6 +78,19 @@ mrview_update_test_() ->
}
}.
+mrview_query_test_() ->
+ {
+ "Check view query functionality",
+ {
+ setup,
+ fun start/0, fun teardown/1,
+ [
+ make_test_case(clustered, [fun should_return_400_for_wrong_order_of_keys/2]),
+ make_test_case(backdoor, [fun should_return_400_for_wrong_order_of_keys/2])
--- End diff --
Since `should_return_400_for_wrong_order_of_keys/2` seems to be independent of PortType, doesn't this just run the exact same test twice? I guess that's not wrong per se, but seems like it's just wasting time.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-couch issue #206: handle errors terms from fabric
Posted by iilyak <gi...@git.apache.org>.
Github user iilyak commented on the issue:
https://github.com/apache/couchdb-couch/pull/206
The PR has been rebased
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-couch pull request #206: handle errors terms from fabric
Posted by iilyak <gi...@git.apache.org>.
Github user iilyak commented on a diff in the pull request:
https://github.com/apache/couchdb-couch/pull/206#discussion_r87679087
--- Diff: test/couchdb_mrview_tests.erl ---
@@ -73,6 +78,19 @@ mrview_update_test_() ->
}
}.
+mrview_query_test_() ->
+ {
+ "Check view query functionality",
+ {
+ setup,
+ fun start/0, fun teardown/1,
+ [
+ make_test_case(clustered, [fun should_return_400_for_wrong_order_of_keys/2]),
+ make_test_case(backdoor, [fun should_return_400_for_wrong_order_of_keys/2])
--- End diff --
@jaydoane It is testing access to the same functionality on both interfaces (clustered | backdoor). Even though the test is the same the setup function getting different arguments and test is running in different environment.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-couch issue #206: handle errors terms from fabric
Posted by jaydoane <gi...@git.apache.org>.
Github user jaydoane commented on the issue:
https://github.com/apache/couchdb-couch/pull/206
LGTM, with the caveat that we seem to be unnecessarily running the same test twice.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-couch pull request #206: handle errors terms from fabric
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/couchdb-couch/pull/206
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---