[GitHub] [flink] dmvk commented on a diff in pull request #22350: [FLINK-31471] Allow setting JobResourceRequirements through WEB UI.

["dmvk (via GitHub)" <gi...@apache.org>]

dmvk commented on code in PR #22350:
URL: https://github.com/apache/flink/pull/22350#discussion_r1158147075


##########
flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/RestHandlerConfiguration.java:
##########
@@ -96,13 +105,20 @@ public static RestHandlerConfiguration fromConfiguration(Configuration configura
 
         final boolean webSubmitEnabled = configuration.getBoolean(WebOptions.SUBMIT_ENABLE);
         final boolean webCancelEnabled = configuration.getBoolean(WebOptions.CANCEL_ENABLE);
+        final boolean webRescaleSupported =
+                JobManagerOptions.SchedulerType.Adaptive.equals(
+                                configuration.get(JobManagerOptions.SCHEDULER))
+                        && configuration.get(JobManagerOptions.SCHEDULER_MODE) == null;
+        final boolean webRescaleEnabled =

Review Comment:
   I was looking at the job cancellation (webCancelEnabled), and that doesn't seem to be the case for it. If this is correct, should we leave it as is and create a follow to implement this for all "web UI mutability features"?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org