You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "xujianhai666 (GitHub)" <gi...@apache.org> on 2020/03/21 12:22:09 UTC
[GitHub] [dubbo-go] xujianhai666 opened pull request #439: feature:
support protobuf
[ Full content available at: https://github.com/apache/dubbo-go/pull/439 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [dubbo-go] fangyincheng commented on pull request #439:
[WIP] feature: support protobuf
Posted by "fangyincheng (GitHub)" <gi...@apache.org>.
the config dir should not referent `impl`.
[ Full content available at: https://github.com/apache/dubbo-go/pull/439 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [dubbo-go] zouyx commented on pull request #439: [WIP]
feature: support protobuf
Posted by "zouyx (GitHub)" <gi...@apache.org>.
maybe add blank line between lisence and package name
[ Full content available at: https://github.com/apache/dubbo-go/pull/439 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [dubbo-go] fangyincheng commented on pull request #439:
[WIP] feature: support protobuf
Posted by "fangyincheng (GitHub)" <gi...@apache.org>.
if not , should panic.
[ Full content available at: https://github.com/apache/dubbo-go/pull/439 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [dubbo-go] fangyincheng commented on pull request #439:
[WIP] feature: support protobuf
Posted by "fangyincheng (GitHub)" <gi...@apache.org>.
please see Url.tostring, and then decide to keep this method or not.
[ Full content available at: https://github.com/apache/dubbo-go/pull/439 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org