You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Michael Park <mc...@gmail.com> on 2015/08/10 02:59:52 UTC
Re: Review Request 37258: stout: Fixed break before braces style for
'enum'.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37258/
-----------------------------------------------------------
(Updated Aug. 10, 2015, 12:59 a.m.)
Review request for mesos, Artem Harutyunyan and Till Toenshoff.
Repository: mesos
Description
-------
See summary.
Left the instances in `3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.pb.cc` and `3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.pb.h` alone since these are supposed to be simulate (and match?) what would be generated by `protobuf`.
Diffs
-----
3rdparty/libprocess/3rdparty/stout/include/stout/option.hpp 549fc46cedb643ef1ebdf8441c332a02ac45016d
3rdparty/libprocess/3rdparty/stout/include/stout/recordio.hpp e8a62175a9c266711064993233e4d224b8f850cd
3rdparty/libprocess/3rdparty/stout/include/stout/strings.hpp ed75f95bbf6c54beea9f7a4d8aaaecaa04735535
Diff: https://reviews.apache.org/r/37258/diff/
Testing
-------
```bash
$ ag --cpp -l -s "enum.*{"
3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.pb.cc
3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.pb.h
```
`make check`
Thanks,
Michael Park
Re: Review Request 37258: stout: Fixed break before braces style for
'enum'.
Posted by Till Toenshoff <to...@me.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37258/#review94713
-----------------------------------------------------------
Ship it!
Ship It!
- Till Toenshoff
On Aug. 10, 2015, 12:59 a.m., Michael Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37258/
> -----------------------------------------------------------
>
> (Updated Aug. 10, 2015, 12:59 a.m.)
>
>
> Review request for mesos, Artem Harutyunyan and Till Toenshoff.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
> Left the instances in `3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.pb.cc` and `3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.pb.h` alone since these are supposed to be simulate (and match?) what would be generated by `protobuf`.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/option.hpp 549fc46cedb643ef1ebdf8441c332a02ac45016d
> 3rdparty/libprocess/3rdparty/stout/include/stout/recordio.hpp e8a62175a9c266711064993233e4d224b8f850cd
> 3rdparty/libprocess/3rdparty/stout/include/stout/strings.hpp ed75f95bbf6c54beea9f7a4d8aaaecaa04735535
>
> Diff: https://reviews.apache.org/r/37258/diff/
>
>
> Testing
> -------
>
> ```bash
> $ ag --cpp -l -s "enum.*{"
> 3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.pb.cc
> 3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.pb.h
> ```
> `make check`
>
>
> Thanks,
>
> Michael Park
>
>