You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@flink.apache.org by se...@apache.org on 2020/09/15 20:13:55 UTC

[flink] 07/11: [refactor][core] Eagerly initialize the FetchTask to support proper unit testing

This is an automated email from the ASF dual-hosted git repository.

sewen pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/flink.git

commit a8206467af0830dcb89623ea068b5ca3b3450c92
Author: Stephan Ewen <se...@apache.org>
AuthorDate: Mon Sep 14 20:51:56 2020 +0200

    [refactor][core] Eagerly initialize the FetchTask to support proper unit testing
    
    Previously, the FetchTask was constructed lazily in the run() method, which gets in the
    way of unit testing via the runOnce() method.
---
 .../base/source/reader/fetcher/SplitFetcher.java        | 17 +++++++++--------
 1 file changed, 9 insertions(+), 8 deletions(-)

diff --git a/flink-connectors/flink-connector-base/src/main/java/org/apache/flink/connector/base/source/reader/fetcher/SplitFetcher.java b/flink-connectors/flink-connector-base/src/main/java/org/apache/flink/connector/base/source/reader/fetcher/SplitFetcher.java
index fa1442e..289dc34 100644
--- a/flink-connectors/flink-connector-base/src/main/java/org/apache/flink/connector/base/source/reader/fetcher/SplitFetcher.java
+++ b/flink-connectors/flink-connector-base/src/main/java/org/apache/flink/connector/base/source/reader/fetcher/SplitFetcher.java
@@ -75,20 +75,21 @@ public class SplitFetcher<E, SplitT extends SourceSplit> implements Runnable {
 		this.isIdle = true;
 		this.wakeUp = new AtomicBoolean(false);
 		this.closed = new AtomicBoolean(false);
+
+		this.fetchTask = new FetchTask<>(
+				splitReader,
+				elementsQueue,
+				ids -> {
+					ids.forEach(assignedSplits::remove);
+					updateIsIdle();
+				},
+				id);
 	}
 
 	@Override
 	public void run() {
 		LOG.info("Starting split fetcher {}", id);
 		try {
-			// Remove the split from the assignments if it is already done.
-			this.fetchTask = new FetchTask<>(
-					splitReader,
-					elementsQueue,
-					ids -> {
-						ids.forEach(assignedSplits::remove);
-						updateIsIdle();
-					}, id);
 			while (!closed.get()) {
 				runOnce();
 			}