You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Zheng Wang (Jira)" <ji...@apache.org> on 2020/06/01 14:54:00 UTC
[jira] [Updated] (HBASE-24486) Remove the unused method online in
admin.rb
[ https://issues.apache.org/jira/browse/HBASE-24486?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Zheng Wang updated HBASE-24486:
-------------------------------
Description:
Skiming the todo list, seems this method not used any more.
{code:java}
# Enables/disables a region by name
def online(region_name, on_off)
# Open meta table
meta = @connection.getTable(org.apache.hadoop.hbase.TableName::META_TABLE_NAME)
# Read region info
# FIXME: fail gracefully if can't find the region
region_bytes = region_name.to_java_bytes
g = org.apache.hadoop.hbase.client.Get.new(region_bytes)
g.addColumn(org.apache.hadoop.hbase.HConstants::CATALOG_FAMILY, org.apache.hadoop.hbase.HConstants::REGIONINFO_QUALIFIER)
hri_bytes = meta.get(g).value
# Change region status
hri = org.apache.hadoop.hbase.util.Writables.getWritable(hri_bytes, org.apache.hadoop.hbase.HRegionInfo.new)
hri.setOffline(on_off)
# Write it back
put = org.apache.hadoop.hbase.client.Put.new(region_bytes)
put.addColumn(org.apache.hadoop.hbase.HConstants::CATALOG_FAMILY,
org.apache.hadoop.hbase.HConstants::REGIONINFO_QUALIFIER,
org.apache.hadoop.hbase.util.Writables.getBytes(hri))
meta.put(put)
end
{code}
was:
Skiming the todo list, and find this method not used any more.
{code:java}
# Enables/disables a region by name
def online(region_name, on_off)
# Open meta table
meta = @connection.getTable(org.apache.hadoop.hbase.TableName::META_TABLE_NAME)
# Read region info
# FIXME: fail gracefully if can't find the region
region_bytes = region_name.to_java_bytes
g = org.apache.hadoop.hbase.client.Get.new(region_bytes)
g.addColumn(org.apache.hadoop.hbase.HConstants::CATALOG_FAMILY, org.apache.hadoop.hbase.HConstants::REGIONINFO_QUALIFIER)
hri_bytes = meta.get(g).value
# Change region status
hri = org.apache.hadoop.hbase.util.Writables.getWritable(hri_bytes, org.apache.hadoop.hbase.HRegionInfo.new)
hri.setOffline(on_off)
# Write it back
put = org.apache.hadoop.hbase.client.Put.new(region_bytes)
put.addColumn(org.apache.hadoop.hbase.HConstants::CATALOG_FAMILY,
org.apache.hadoop.hbase.HConstants::REGIONINFO_QUALIFIER,
org.apache.hadoop.hbase.util.Writables.getBytes(hri))
meta.put(put)
end
{code}
> Remove the unused method online in admin.rb
> -------------------------------------------
>
> Key: HBASE-24486
> URL: https://issues.apache.org/jira/browse/HBASE-24486
> Project: HBase
> Issue Type: Improvement
> Reporter: Zheng Wang
> Assignee: Zheng Wang
> Priority: Minor
>
> Skiming the todo list, seems this method not used any more.
>
> {code:java}
> # Enables/disables a region by name
> def online(region_name, on_off)
> # Open meta table
> meta = @connection.getTable(org.apache.hadoop.hbase.TableName::META_TABLE_NAME)
> # Read region info
> # FIXME: fail gracefully if can't find the region
> region_bytes = region_name.to_java_bytes
> g = org.apache.hadoop.hbase.client.Get.new(region_bytes)
> g.addColumn(org.apache.hadoop.hbase.HConstants::CATALOG_FAMILY, org.apache.hadoop.hbase.HConstants::REGIONINFO_QUALIFIER)
> hri_bytes = meta.get(g).value
> # Change region status
> hri = org.apache.hadoop.hbase.util.Writables.getWritable(hri_bytes, org.apache.hadoop.hbase.HRegionInfo.new)
> hri.setOffline(on_off)
> # Write it back
> put = org.apache.hadoop.hbase.client.Put.new(region_bytes)
> put.addColumn(org.apache.hadoop.hbase.HConstants::CATALOG_FAMILY,
> org.apache.hadoop.hbase.HConstants::REGIONINFO_QUALIFIER,
> org.apache.hadoop.hbase.util.Writables.getBytes(hri))
> meta.put(put)
> end
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)