You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by resmo <gi...@git.apache.org> on 2015/06/23 10:19:34 UTC
[GitHub] cloudstack pull request: CLOUDSTACK-8578: fix listVirtualMachines ...
GitHub user resmo opened a pull request:
https://github.com/apache/cloudstack/pull/510
CLOUDSTACK-8578: fix listVirtualMachines does not return deleted mach…
…ines when zone is specified
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/resmo/cloudstack fix/CLOUDSTACK-8578
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/510.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #510
----
commit 477fdef6d6b07de8f0b8c4fd2a99315be054264b
Author: Rene Moser <re...@apache.org>
Date: 2015-06-23T08:17:25Z
CLOUDSTACK-8578: fix listVirtualMachines does not return deleted machines when zone is specified
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8578: fix listVirtualMachines ...
Posted by bhaisaab <gi...@git.apache.org>.
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/510#issuecomment-114495407
@resmo can you send a doc PR so at least we can document this in release notes?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8578: fix listVirtualMachines ...
Posted by DaanHoogland <gi...@git.apache.org>.
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/510#issuecomment-114432879
why should we return machines that no longer exist?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8578: fix listVirtualMachines ...
Posted by bhaisaab <gi...@git.apache.org>.
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/510#issuecomment-114495233
this can potentially break clients depending on the behaviour when zoneid is passed
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8578: fix listVirtualMachines ...
Posted by DaanHoogland <gi...@git.apache.org>.
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/510#issuecomment-114486026
good point so backwards compatibility is a glass eye anyway;) will merge
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8578: fix listVirtualMachines ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/510
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8578: fix listVirtualMachines ...
Posted by resmo <gi...@git.apache.org>.
Github user resmo commented on the pull request:
https://github.com/apache/cloudstack/pull/510#issuecomment-114502611
@bhaisaab Ok. I'll make a doc PR. We could probably think about extending the list API to a state e.g. `present` which returns all VMs in states `starting, running, stopped, stopping'. So the *old* behaviour could be used as well in a proper way. Any thoughts?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8578: fix listVirtualMachines ...
Posted by resmo <gi...@git.apache.org>.
Github user resmo commented on the pull request:
https://github.com/apache/cloudstack/pull/510#issuecomment-114465874
@DaanHoogland We already do :). User permissions API is **not affected** of this change however.
The API does already return VMs `listVirtualMacines` in `destroyed` state if you have *admin* permissions.
But if you provide `zoneid` in `listVirtualMacines` with *admin* permissions, it does not return VMs in `destroyed` state. This makes no sense to me. The bug was already fixed in CLOUDSTACK-284 but then the bug was reimplemented by accident.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---