You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Michael Park <mp...@apache.org> on 2016/04/05 21:48:45 UTC

Review Request 45767: Fixed commit message hook to iterate over the lines rather than words.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45767/
-----------------------------------------------------------

Review request for mesos, Joerg Schad and Vinod Kone.


Bugs: MESOS-5125
    https://issues.apache.org/jira/browse/MESOS-5125


Repository: mesos


Description
-------

See summary.


Diffs
-----

  support/hooks/commit-msg d3d5415bf6a243def05cf79f4af2b136b9866d68 

Diff: https://reviews.apache.org/r/45767/diff/


Testing
-------

Added `echo $LINE` and verified that `$LINE` is the full line, rather than words.


Thanks,

Michael Park


Re: Review Request 45767: Fixed commit message hook to iterate over the lines rather than words.

Posted by Joerg Schad <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45767/#review127302
-----------------------------------------------------------


Ship it!




Thanks!

- Joerg Schad


On April 5, 2016, 7:48 p.m., Michael Park wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45767/
> -----------------------------------------------------------
> 
> (Updated April 5, 2016, 7:48 p.m.)
> 
> 
> Review request for mesos, Joerg Schad and Vinod Kone.
> 
> 
> Bugs: MESOS-5125
>     https://issues.apache.org/jira/browse/MESOS-5125
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   support/hooks/commit-msg d3d5415bf6a243def05cf79f4af2b136b9866d68 
> 
> Diff: https://reviews.apache.org/r/45767/diff/
> 
> 
> Testing
> -------
> 
> Added `echo $LINE` and verified that `$LINE` is the full line, rather than words.
> 
> 
> Thanks,
> 
> Michael Park
> 
>