You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by ru...@apache.org on 2023/12/18 17:47:02 UTC

(superset) branch master updated: chore(cleanup): removing redundant rendering logic in telemetry pixel (#26293)

This is an automated email from the ASF dual-hosted git repository.

rusackas pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/superset.git


The following commit(s) were added to refs/heads/master by this push:
     new eb4b41233b chore(cleanup): removing redundant rendering logic in telemetry pixel (#26293)
eb4b41233b is described below

commit eb4b41233bc4bdcb5a578661712e977b60ff88c5
Author: Evan Rusackas <ev...@preset.io>
AuthorDate: Mon Dec 18 10:46:55 2023 -0700

    chore(cleanup): removing redundant rendering logic in telemetry pixel (#26293)
---
 superset-frontend/src/components/TelemetryPixel/index.tsx | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/superset-frontend/src/components/TelemetryPixel/index.tsx b/superset-frontend/src/components/TelemetryPixel/index.tsx
index 6bfe1d20b9..6c7ce106e6 100644
--- a/superset-frontend/src/components/TelemetryPixel/index.tsx
+++ b/superset-frontend/src/components/TelemetryPixel/index.tsx
@@ -45,8 +45,7 @@ const TelemetryPixel = ({
   build = 'unknownBuild',
 }: TelemetryPixelProps): React.ReactElement | null => {
   const pixelPath = `https://apachesuperset.gateway.scarf.sh/pixel/${PIXEL_ID}/${version}/${sha}/${build}`;
-  return process.env.SCARF_ANALYTICS === 'false' ||
-    process.env.SCARF_ANALYTICS === 'false' ? null : (
+  return process.env.SCARF_ANALYTICS === 'false' ? null : (
     <img
       referrerPolicy="no-referrer-when-downgrade"
       src={pixelPath}