You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2019/10/01 12:12:29 UTC

[GitHub] [maven-surefire] Col-E edited a comment on issue #245: Surefire-1584: Add option to rerun failing tests for JUnit5

Col-E edited a comment on issue #245: Surefire-1584: Add option to rerun failing tests for JUnit5 
URL: https://github.com/apache/maven-surefire/pull/245#issuecomment-537007114
 
 
   > Pls check if the difference between those two methods is what I used in the previous comment because I was too fast to compare in detail. Thx
   
   I noticed that:
   ```java
    source = testPlan.getParent( testIdentifier )
             .map( this::toClassMethodName )
   ```
   should probably be:
   ```java
    source = testPlan.getParent( testIdentifier )
             .map( i -> toClassMethodName( i, usePlan ) )
   ```
   I think that should be it for any possible regressions. Fixed in 9886eb5.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services