You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@iceberg.apache.org by ze...@apache.org on 2026/07/03 18:24:31 UTC

(iceberg-go) branch main updated: fix(table): clone metadata builder properties (#1353)

This is an automated email from the ASF dual-hosted git repository.

zeroshade pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/iceberg-go.git


The following commit(s) were added to refs/heads/main by this push:
     new 04573bc1 fix(table): clone metadata builder properties (#1353)
04573bc1 is described below

commit 04573bc120b1205013120c7d81511ebd9b4555ca
Author: Minh Vu <vu...@gmail.com>
AuthorDate: Fri Jul 3 20:24:26 2026 +0200

    fix(table): clone metadata builder properties (#1353)
    
    ## Summary
    
    `MetadataBuilder.SetProperties` kept the caller-provided properties map
    when the builder had no existing properties. That meant later changes to
    the caller map could mutate builder state after `SetProperties`
    returned.
    
    This clones incoming properties before storing them in the builder and
    before recording the pending set-properties update. The builder
    aggregate properties and the recorded update now stay independent from
    caller-owned maps and from later builder property merges.
    
    ## Testing
    
    - `go test ./table`
    - `go test ./...`
---
 table/metadata.go                       |  7 ++++---
 table/metadata_builder_internal_test.go | 25 +++++++++++++++++++++++++
 2 files changed, 29 insertions(+), 3 deletions(-)

diff --git a/table/metadata.go b/table/metadata.go
index 2f9bf354..12138799 100644
--- a/table/metadata.go
+++ b/table/metadata.go
@@ -780,11 +780,12 @@ func (b *MetadataBuilder) SetProperties(props iceberg.Properties) error {
 		}
 	}
 
-	b.updates = append(b.updates, NewSetPropertiesUpdate(props))
+	updates := maps.Clone(props)
+	b.updates = append(b.updates, NewSetPropertiesUpdate(updates))
 	if b.props == nil {
-		b.props = props
+		b.props = maps.Clone(updates)
 	} else {
-		maps.Copy(b.props, props)
+		maps.Copy(b.props, updates)
 	}
 
 	return nil
diff --git a/table/metadata_builder_internal_test.go b/table/metadata_builder_internal_test.go
index 134374d1..cf7fafbf 100644
--- a/table/metadata_builder_internal_test.go
+++ b/table/metadata_builder_internal_test.go
@@ -1182,6 +1182,31 @@ func TestSetReservedPropertiesFails(t *testing.T) {
 	require.ErrorContains(t, err, "can't set reserved property "+PropertyCurrentSnapshotId)
 }
 
+func TestSetPropertiesClonesProperties(t *testing.T) {
+	builder := builderWithoutChanges(2)
+
+	props := iceberg.Properties{"property": "value"}
+	require.NoError(t, builder.SetProperties(props))
+
+	props["property"] = "mutated"
+	props["added"] = "mutated"
+
+	require.Equal(t, "value", builder.props["property"])
+	require.NotContains(t, builder.props, "added")
+
+	require.Len(t, builder.updates, 1)
+	firstUpdate := builder.updates[0].(*setPropertiesUpdate)
+	require.Equal(t, iceberg.Properties{"property": "value"}, firstUpdate.Updates)
+
+	moreProps := iceberg.Properties{"another-property": "another-value"}
+	require.NoError(t, builder.SetProperties(moreProps))
+	moreProps["another-property"] = "mutated"
+
+	require.Equal(t, iceberg.Properties{"property": "value"}, firstUpdate.Updates)
+	require.Equal(t, "another-value", builder.props["another-property"])
+	require.Equal(t, iceberg.Properties{"another-property": "another-value"}, builder.updates[1].(*setPropertiesUpdate).Updates)
+}
+
 func TestRemoveReservedPropertiesFails(t *testing.T) {
 	builder := builderWithoutChanges(2)