[jira] Commented: (HADOOP-5023) Add Tomcat support to hdfsproxy

["Chris Douglas (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HADOOP-5023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12676167#action_12676167 ] 

Chris Douglas commented on HADOOP-5023:
---------------------------------------

* On my machine, running {{ant -Dtestcase=FOO test}} 
*# Still runs the unit test
*# Fails (times out)

For (1), all modules should respect the testcase var (Chukwa has an example). If {{FOO}} isn't a test in your suite, it should not run. Similarly, {{ant -Dtestcase=TestHdfsProxy test}} should run only that test. (2) is a different issue altogether. Does this work for you on a fresh checkout?
* If the "UnitTest" parameter is in the URI query:
{noformat}
+    boolean unitTest = false;
+    if (rqst.getParameter("UnitTest") != null) unitTest = true;
{noformat}

What does this do?
* The content of hdfsproxy/conf/\{user-permissions,user-certs\} appears to be for testing. If so, it belongs in hdfsproxy/src/test
* This should be removed from tomcat-web.xml:
{noformat}
+   <!--<context-param>
+      <param-name>hdfsproxy.dfs.namenode.address</param-name>
+      <param-value>ucdev19.inktomisearch.com:54321</param-value>
+      <description> name node address </description>
+    </context-param>-->
{noformat}

Is this value duplicated in the hdfsproxy configuration and the tomcat configuration?
* These dependencies look suspect (ivy.xml). Are they necessary?
{noformat}
+   <dependency org="httpunit" name="httpunit" rev="1.6" conf="common->master"/>
+   <dependency org="htmlunit" name="htmlunit" rev="1.10" conf="common->master"/>
+
+   <dependency org="aspectj" name="aspectjrt" rev="1.5.3" conf="common->master"/>
{noformat}
* I'm not sure ProxyUtils::sendCommand should be a public method. Given that it will overwrite several system properties and no tool has a demonstrable need for it yet, it would be better if it were package-private for now.

> Add Tomcat support to hdfsproxy
> -------------------------------
>
>                 Key: HADOOP-5023
>                 URL: https://issues.apache.org/jira/browse/HADOOP-5023
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: contrib/hdfsproxy
>            Reporter: Kan Zhang
>            Assignee: zhiyong zhang
>         Attachments: HADOOP-5023.patch, HADOOP-5023.patch, HADOOP-5023.patch
>
>
> We plan to add Tomcat support to hdfsproxy since Tomcat has good production support at Yahoo.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.