You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by ma...@apache.org on 2025/08/26 16:16:09 UTC
(superset) branch master updated: fix(docker): remove --with-threads from remaining dev workflows for DuckDB compatibility (#34851)
This is an automated email from the ASF dual-hosted git repository.
maximebeauchemin pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/superset.git
The following commit(s) were added to refs/heads/master by this push:
new 659db162d6 fix(docker): remove --with-threads from remaining dev workflows for DuckDB compatibility (#34851)
659db162d6 is described below
commit 659db162d65d8856d871b64e6dda4d16a906561d
Author: Maxime Beauchemin <ma...@gmail.com>
AuthorDate: Tue Aug 26 09:16:03 2025 -0700
fix(docker): remove --with-threads from remaining dev workflows for DuckDB compatibility (#34851)
Co-authored-by: Claude <no...@anthropic.com>
---
Makefile | 2 +-
docker-compose-light.yml | 11 +++--------
docker-compose.yml | 4 ++--
docker/docker-bootstrap.sh | 2 +-
4 files changed, 7 insertions(+), 12 deletions(-)
diff --git a/Makefile b/Makefile
index 1c9aa80ff5..4a7121fd34 100644
--- a/Makefile
+++ b/Makefile
@@ -91,7 +91,7 @@ js-format:
cd superset-frontend; npm run prettier
flask-app:
- flask run -p 8088 --with-threads --reload --debugger
+ flask run -p 8088 --reload --debugger
node-app:
cd superset-frontend; npm run dev-server
diff --git a/docker-compose-light.yml b/docker-compose-light.yml
index c75dc671be..ae176c0c33 100644
--- a/docker-compose-light.yml
+++ b/docker-compose-light.yml
@@ -116,13 +116,8 @@ services:
DATABASE_HOST: db-light
DATABASE_DB: superset_light
POSTGRES_DB: superset_light
- SUPERSET__SQLALCHEMY_EXAMPLES_URI: "duckdb:////app/data/examples.duckdb?access_mode=read_only"
+ SUPERSET__SQLALCHEMY_EXAMPLES_URI: "duckdb:////app/data/examples.duckdb"
SUPERSET_CONFIG_PATH: /app/docker/pythonpath_dev/superset_config_docker_light.py
- # DuckDB concurrency configuration: DuckDB examples database uses read-only mode
- # to allow concurrent access from multiple workers/threads without file locking issues
- # SERVER_WORKER_AMOUNT: 8
- # SERVER_THREADS_AMOUNT: 1
- # SERVER_WORKER_CLASS: sync
superset-init-light:
build:
@@ -142,7 +137,7 @@ services:
DATABASE_HOST: db-light
DATABASE_DB: superset_light
POSTGRES_DB: superset_light
- SUPERSET__SQLALCHEMY_EXAMPLES_URI: "duckdb:////app/data/examples.duckdb?access_mode=read_only"
+ SUPERSET__SQLALCHEMY_EXAMPLES_URI: "duckdb:////app/data/examples.duckdb"
SUPERSET_CONFIG_PATH: /app/docker/pythonpath_dev/superset_config_docker_light.py
healthcheck:
disable: true
@@ -196,7 +191,7 @@ services:
DATABASE_DB: test
POSTGRES_DB: test
SUPERSET__SQLALCHEMY_DATABASE_URI: postgresql+psycopg2://superset:superset@db-light:5432/test
- SUPERSET__SQLALCHEMY_EXAMPLES_URI: "duckdb:////app/data/examples.duckdb?access_mode=read_only"
+ SUPERSET__SQLALCHEMY_EXAMPLES_URI: "duckdb:////app/data/examples.duckdb"
SUPERSET_CONFIG: superset_test_config_light
PYTHONPATH: /app/pythonpath:/app/docker/pythonpath_dev:/app
diff --git a/docker-compose.yml b/docker-compose.yml
index 252e8ffe0b..d58ed84488 100644
--- a/docker-compose.yml
+++ b/docker-compose.yml
@@ -109,7 +109,7 @@ services:
condition: service_completed_successfully
volumes: *superset-volumes
environment:
- SUPERSET__SQLALCHEMY_EXAMPLES_URI: "duckdb:////app/data/examples.duckdb?access_mode=read_only"
+ SUPERSET__SQLALCHEMY_EXAMPLES_URI: "duckdb:////app/data/examples.duckdb"
superset-websocket:
container_name: superset_websocket
@@ -162,7 +162,7 @@ services:
user: *superset-user
volumes: *superset-volumes
environment:
- SUPERSET__SQLALCHEMY_EXAMPLES_URI: "duckdb:////app/data/examples.duckdb?access_mode=read_only"
+ SUPERSET__SQLALCHEMY_EXAMPLES_URI: "duckdb:////app/data/examples.duckdb"
healthcheck:
disable: true
diff --git a/docker/docker-bootstrap.sh b/docker/docker-bootstrap.sh
index fd017622a1..2f466fea84 100755
--- a/docker/docker-bootstrap.sh
+++ b/docker/docker-bootstrap.sh
@@ -72,7 +72,7 @@ case "${1}" in
;;
app)
echo "Starting web app (using development server)..."
- flask run -p $PORT --with-threads --reload --debugger --host=0.0.0.0
+ flask run -p $PORT --reload --debugger --host=0.0.0.0
;;
app-gunicorn)
echo "Starting web app..."