[jira] [Created] (LUCENE-6999) Lucene60PointsWriter has a buggy close method

["Robert Muir (JIRA)" <ji...@apache.org>]

Robert Muir created LUCENE-6999:
-----------------------------------

             Summary: Lucene60PointsWriter has a buggy close method
                 Key: LUCENE-6999
                 URL: https://issues.apache.org/jira/browse/LUCENE-6999
             Project: Lucene - Core
          Issue Type: Bug
            Reporter: Robert Muir


This will leak a file handle on e.g. disk full or other exceptions
{noformat}
  @Override
  public void close() throws IOException {
    if (closed == false) {
      CodecUtil.writeFooter(dataOut); // something bad happens
      dataOut.close();
{noformat}

I'm not a fan of these complex close methods, should we add a finish() to the codec api or similar?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org