You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "tustvold (via GitHub)" <gi...@apache.org> on 2023/07/29 16:24:13 UTC
[GitHub] [arrow-rs] tustvold opened a new pull request, #4582: Use contains_nulls in ArrayData equality of byte arrays
tustvold opened a new pull request, #4582:
URL: https://github.com/apache/arrow-rs/pull/4582
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Closes #.
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!---
If there are any breaking changes to public APIs, please add the `breaking change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold commented on a diff in pull request #4582: Use contains_nulls in ArrayData equality of byte arrays
Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold commented on code in PR #4582:
URL: https://github.com/apache/arrow-rs/pull/4582#discussion_r1278318645
##########
arrow-data/src/equal/variable_size.rs:
##########
@@ -59,14 +59,9 @@ pub(super) fn variable_sized_equal<T: ArrowNativeType + Integer>(
let lhs_values = lhs.buffers()[1].as_slice();
let rhs_values = rhs.buffers()[1].as_slice();
- let lhs_null_count = count_nulls(lhs.nulls(), lhs_start, len);
- let rhs_null_count = count_nulls(rhs.nulls(), rhs_start, len);
-
- if lhs_null_count == 0
- && rhs_null_count == 0
- && !lhs_values.is_empty()
Review Comment:
I'm not sure of the point of this check, as the alternative branch calls through to the same function regardless...
##########
arrow-data/src/equal/variable_size.rs:
##########
@@ -59,14 +59,9 @@ pub(super) fn variable_sized_equal<T: ArrowNativeType + Integer>(
let lhs_values = lhs.buffers()[1].as_slice();
let rhs_values = rhs.buffers()[1].as_slice();
- let lhs_null_count = count_nulls(lhs.nulls(), lhs_start, len);
- let rhs_null_count = count_nulls(rhs.nulls(), rhs_start, len);
-
- if lhs_null_count == 0
- && rhs_null_count == 0
- && !lhs_values.is_empty()
Review Comment:
I'm not sure of the point of this check, as the alternative branch calls through to the same function regardless...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold merged pull request #4582: Use contains_nulls in ArrayData equality of byte arrays
Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold merged PR #4582:
URL: https://github.com/apache/arrow-rs/pull/4582
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] alamb commented on a diff in pull request #4582: Use contains_nulls in ArrayData equality of byte arrays
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on code in PR #4582:
URL: https://github.com/apache/arrow-rs/pull/4582#discussion_r1280455576
##########
arrow-data/src/equal/variable_size.rs:
##########
@@ -59,14 +59,9 @@ pub(super) fn variable_sized_equal<T: ArrowNativeType + Integer>(
let lhs_values = lhs.buffers()[1].as_slice();
let rhs_values = rhs.buffers()[1].as_slice();
- let lhs_null_count = count_nulls(lhs.nulls(), lhs_start, len);
- let rhs_null_count = count_nulls(rhs.nulls(), rhs_start, len);
-
- if lhs_null_count == 0
- && rhs_null_count == 0
- && !lhs_values.is_empty()
- && !rhs_values.is_empty()
- {
+ // Only checking one null mask here because by the time the control flow reaches
Review Comment:
I double checked this was the case and indeed the call site `equal` checks the null count already and then calls `equal_values` which then calls this function
https://github.com/apache/arrow-rs/blob/a5d9118c7b420bb413b642cfc024770e38594aab/arrow-data/src/equal/mod.rs#L170-L175
https://github.com/apache/arrow-rs/blob/a5d9118c7b420bb413b642cfc024770e38594aab/arrow-data/src/equal/mod.rs#L100
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org