You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2021/01/22 20:16:26 UTC
[GitHub] [hudi] vinothchandar commented on a change in pull request #2426: [HUDI-304] Configure spotless and java style
vinothchandar commented on a change in pull request #2426:
URL: https://github.com/apache/hudi/pull/2426#discussion_r562873786
##########
File path: hudi-sync/hudi-hive-sync/src/main/java/org/apache/hudi/hive/HoodieHiveClient.java
##########
@@ -18,36 +18,36 @@
package org.apache.hudi.hive;
-import java.io.UnsupportedEncodingException;
-import java.net.URLDecoder;
-import java.nio.charset.StandardCharsets;
-import org.apache.hadoop.hive.metastore.api.FieldSchema;
-import org.apache.hadoop.hive.metastore.api.MetaException;
-import org.apache.hadoop.hive.metastore.api.Partition;
-import org.apache.hadoop.hive.metastore.api.Table;
-import org.apache.hadoop.hive.metastore.api.Database;
import org.apache.hudi.common.fs.FSUtils;
import org.apache.hudi.common.fs.StorageSchemes;
import org.apache.hudi.common.table.timeline.HoodieTimeline;
import org.apache.hudi.common.util.Option;
import org.apache.hudi.common.util.ValidationUtils;
import org.apache.hudi.hive.util.HiveSchemaUtil;
+import org.apache.hudi.sync.common.AbstractSyncHoodieClient;
import org.apache.hadoop.fs.FileSystem;
import org.apache.hadoop.fs.Path;
import org.apache.hadoop.hive.conf.HiveConf;
import org.apache.hadoop.hive.metastore.IMetaStoreClient;
+import org.apache.hadoop.hive.metastore.api.Database;
Review comment:
does this organization work consistenty with `Code > Optimize Imports` in IntelliJ? This was the large stick point from last time.
##########
File path: hudi-sync/hudi-hive-sync/src/main/java/org/apache/hudi/hive/HoodieHiveClient.java
##########
@@ -76,12 +76,18 @@
private HiveConf configuration;
public HoodieHiveClient(HiveSyncConfig cfg, HiveConf configuration, FileSystem fs) {
- super(cfg.basePath, cfg.assumeDatePartitioning, cfg.useFileListingFromMetadata, cfg.verifyMetadataFileListing, fs);
+ super(
+ cfg.basePath,
Review comment:
personally, not a great fan of using a full line for each method argument. Where is this style coming from?
I would be happy to concede, but like to understand what style we are picking here.
##########
File path: pom.xml
##########
@@ -198,34 +200,35 @@
</execution>
</executions>
</plugin>
-<!--
- See https://jira.apache.org/jira/browse/HUDI-304
<plugin>
<groupId>com.diffplug.spotless</groupId>
<artifactId>spotless-maven-plugin</artifactId>
- <version>1.24.3</version>
+ <version>${spotless.version}</version>
<configuration>
<java>
- <eclipse>
- <file>${main.basedir}/style/eclipse-java-google-style.xml</file>
- <version>4.10.0</version>
- </eclipse>
- </java>
- <scala>
+ <googleJavaFormat>
Review comment:
what does Flink use? I think it does `AOSP` ? the wraps are lot more nicer, the one arg per line, really makes it hard to get a good chunk of code read in one screen.
##########
File path: pom.xml
##########
@@ -198,34 +200,35 @@
</execution>
</executions>
</plugin>
-<!--
- See https://jira.apache.org/jira/browse/HUDI-304
<plugin>
<groupId>com.diffplug.spotless</groupId>
<artifactId>spotless-maven-plugin</artifactId>
- <version>1.24.3</version>
+ <version>${spotless.version}</version>
<configuration>
<java>
- <eclipse>
- <file>${main.basedir}/style/eclipse-java-google-style.xml</file>
- <version>4.10.0</version>
- </eclipse>
- </java>
- <scala>
+ <googleJavaFormat>
Review comment:
e.g https://github.com/apache/flink/blob/master/flink-clients/src/main/java/org/apache/flink/client/ClientUtils.java
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org