[jira] [Commented] (YETUS-45) the test patch script should check for filenames that differ only in case

["Sean Busbey (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/YETUS-45?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14946374#comment-14946374 ] 

Sean Busbey commented on YETUS-45:
----------------------------------

please generate patches with {{git format-patch}}; a [brief guide is available in the contributor guide|http://yetus.apache.org/contribute/#submitting-changes].

please correct shellcheck warnings:
{code}
yetus busbey$ shellcheck dev-support/test-patch.d/dupname.sh 

In dev-support/test-patch.d/dupname.sh line 1:
# Licensed to the Apache Software Foundation (ASF) under one or more
^-- SC2148: Tips depend on target shell and yours is unknown. Add a shebang.

{code}

Looks like we add a footer:

{code}
+    add_footer_table duplicated "@@BASE@@/duplicatednames.txt"
{code}

but I don't see us writing to that file at all?

{code}
Kengo Seki ,Thanks for your review, but intial comment by Allen Wittenauer suggest the code should be less complex ,hence i made the logic into one single loop ,and the same will handle the duplicate values . Allen Wittenauer please suggest which approach would be suitable
{code}

I don't see where the current patch checks against files already in the source tree. Personally, I find the two loops easier to follow.

> the test patch script should check for filenames that differ only in case
> -------------------------------------------------------------------------
>
>                 Key: YETUS-45
>                 URL: https://issues.apache.org/jira/browse/YETUS-45
>             Project: Yetus
>          Issue Type: New Feature
>          Components: Test Patch
>            Reporter: Owen O'Malley
>            Assignee: Jagadesh Kiran N
>              Labels: test-patch
>         Attachments: HADOOP-4258.001.patch, HADOOP-4258.HADOOP-12111.00.patch, HADOOP-4258.HADOOP-12111.01.patch, HADOOP-4258.HADOOP-12111.02.patch, YETUS-45-03.patch
>
>
> It would be nice if the test patch script warned about filenames that differ only in case. We recently had a patch committed that had a pair of colliding filenames and subversion broke badly on my Mac.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)