You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/06/07 08:14:38 UTC

[GitHub] [flink] lincoln-lil commented on pull request #19778: [FLINK-27418][table-planner] fix topN retraction for previously delet…

lincoln-lil commented on PR #19778:
URL: https://github.com/apache/flink/pull/19778#issuecomment-1148345509

   @rovboyko Thanks for fixing it!  The change looks good to me and I've checked the other two places which also invoke the collectDelete without rownumber(UpdatableTopNFunction#L538 and AppendOnlyTopNFunction#L242), no problem there.
   Although this fix adds a bit of serialization overhead, correctness is paramount, and I can't think of a better way to do copy on demand. 
   cc @wuchong if you have some time to double check,  it would be much appreciated.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org