You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/08/18 11:47:22 UTC
[GitHub] [incubator-superset] codecov-io edited a comment on issue #8058:
Add docstrings and typing to db_engine_specs and sql_parse
codecov-io edited a comment on issue #8058: Add docstrings and typing to db_engine_specs and sql_parse
URL: https://github.com/apache/incubator-superset/pull/8058#issuecomment-522268208
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8058?src=pr&el=h1) Report
> Merging [#8058](https://codecov.io/gh/apache/incubator-superset/pull/8058?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/46f4da5fbe3e7c0f27c673af3f8d2e32396fd4da?src=pr&el=desc) will **decrease** coverage by `7.48%`.
> The diff coverage is `97.67%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/8058?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #8058 +/- ##
==========================================
- Coverage 73.21% 65.72% -7.49%
==========================================
Files 115 469 +354
Lines 11873 22596 +10723
Branches 0 2446 +2446
==========================================
+ Hits 8693 14852 +6159
- Misses 3180 7624 +4444
- Partials 0 120 +120
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/8058?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engine\_specs/bigquery.py](https://codecov.io/gh/apache/incubator-superset/pull/8058/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2JpZ3F1ZXJ5LnB5) | `52.23% <100%> (+7.41%)` | :arrow_up: |
| [superset/db\_engine\_specs/drill.py](https://codecov.io/gh/apache/incubator-superset/pull/8058/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2RyaWxsLnB5) | `54.16% <100%> (+9.16%)` | :arrow_up: |
| [superset/db\_engine\_specs/kylin.py](https://codecov.io/gh/apache/incubator-superset/pull/8058/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2t5bGluLnB5) | `53.84% <100%> (+8.39%)` | :arrow_up: |
| [superset/db\_engine\_specs/db2.py](https://codecov.io/gh/apache/incubator-superset/pull/8058/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2RiMi5weQ==) | `85.71% <100%> (+3.89%)` | :arrow_up: |
| [superset/db\_engine\_specs/teradata.py](https://codecov.io/gh/apache/incubator-superset/pull/8058/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3RlcmFkYXRhLnB5) | `88.88% <100%> (+1.38%)` | :arrow_up: |
| [superset/sql\_parse.py](https://codecov.io/gh/apache/incubator-superset/pull/8058/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3BhcnNlLnB5) | `99.22% <100%> (+0.01%)` | :arrow_up: |
| [superset/db\_engine\_specs/athena.py](https://codecov.io/gh/apache/incubator-superset/pull/8058/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2F0aGVuYS5weQ==) | `57.89% <100%> (+11.22%)` | :arrow_up: |
| [superset/db\_engine\_specs/impala.py](https://codecov.io/gh/apache/incubator-superset/pull/8058/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2ltcGFsYS5weQ==) | `65% <100%> (+15%)` | :arrow_up: |
| [superset/db\_engine\_specs/snowflake.py](https://codecov.io/gh/apache/incubator-superset/pull/8058/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Nub3dmbGFrZS5weQ==) | `59.09% <100%> (+4.09%)` | :arrow_up: |
| [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/incubator-superset/pull/8058/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `96.55% <100%> (+1.09%)` | :arrow_up: |
| ... and [364 more](https://codecov.io/gh/apache/incubator-superset/pull/8058/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8058?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8058?src=pr&el=footer). Last update [46f4da5...f6df94c](https://codecov.io/gh/apache/incubator-superset/pull/8058?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org