You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jmeter-dev@jakarta.apache.org by se...@apache.org on 2008/11/13 19:51:38 UTC

svn commit: r713786 - /jakarta/jmeter/trunk/src/protocol/ldap/org/apache/jmeter/protocol/ldap/config/gui/LdapExtConfigGui.java

Author: sebb
Date: Thu Nov 13 10:51:38 2008
New Revision: 713786

URL: http://svn.apache.org/viewvc?rev=713786&view=rev
Log:
Fix Language change by making the strings class variables (non-static)

Modified:
    jakarta/jmeter/trunk/src/protocol/ldap/org/apache/jmeter/protocol/ldap/config/gui/LdapExtConfigGui.java

Modified: jakarta/jmeter/trunk/src/protocol/ldap/org/apache/jmeter/protocol/ldap/config/gui/LdapExtConfigGui.java
URL: http://svn.apache.org/viewvc/jakarta/jmeter/trunk/src/protocol/ldap/org/apache/jmeter/protocol/ldap/config/gui/LdapExtConfigGui.java?rev=713786&r1=713785&r2=713786&view=diff
==============================================================================
--- jakarta/jmeter/trunk/src/protocol/ldap/org/apache/jmeter/protocol/ldap/config/gui/LdapExtConfigGui.java (original)
+++ jakarta/jmeter/trunk/src/protocol/ldap/org/apache/jmeter/protocol/ldap/config/gui/LdapExtConfigGui.java Thu Nov 13 10:51:38 2008
@@ -79,12 +79,18 @@
     private JTextField port = new JTextField(20);
 
     /*
-     * N.B. These entries MUST agree with the LDAP SearchControls SCOPE_LEVELS
+     * N.B. These entry indexes MUST agree with the SearchControls SCOPE_LEVELS, i.e.
+     * 
+     * javax.naming.directory.SearchControls.OBJECT_SCOPE, ONELEVEL_SCOPE, SUBTREE_SCOPE
+     * 
      * These have the values 0,1,2 so can be used as indexes in the array
      * as well as the value for the search itself.
+     * 
+     * N.B. Although the strings are used to set and get the options, language change
+     * does not currently cause a problem, because that always saves the current settings first,
+     * and then recreates all the GUI classes.
      */
-    // TODO I18N
-    private static final String[] SCOPE_STRINGS = new String[]{
+    private final String[] SCOPE_STRINGS = new String[]{
         JMeterUtils.getResString("ldap_search_baseobject"),// $NON-NLS-1$
         JMeterUtils.getResString("ldap_search_onelevel"),// $NON-NLS-1$
         JMeterUtils.getResString("ldap_search_subtree"),// $NON-NLS-1$



---------------------------------------------------------------------
To unsubscribe, e-mail: jmeter-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: jmeter-dev-help@jakarta.apache.org