[GitHub] [arrow] kou commented on a diff in pull request #14319: ARROW-17240: [CI][Release] Verify wheels in nightly CI

[GitBox <gi...@apache.org>]

kou commented on code in PR #14319:
URL: https://github.com/apache/arrow/pull/14319#discussion_r989508199


##########
dev/tasks/python-wheels/github.linux.amd64.yml:
##########
@@ -31,12 +31,16 @@ jobs:
     steps:
       {{ macros.github_checkout_arrow()|indent }}
       {{ macros.github_install_archery()|indent }}
-      {{ macros.github_login_dockerhub()|indent }}

Review Comment:
   Ah... I forgot it...
   Thanks. I revert this.



##########
dev/tasks/python-wheels/github.linux.amd64.yml:
##########
@@ -48,9 +52,83 @@ jobs:
       {{ macros.github_upload_gemfury("arrow/python/repaired_wheels/*.whl")|indent }}
 
       {% if arrow.is_default_branch() %}
+      {{ macros.github_login_dockerhub()|indent }}
       - name: Push Docker Image
         shell: bash
         run: |
           archery docker push python-wheel-manylinux-{{ manylinux_version }}
           archery docker push python-wheel-manylinux-test-unittests
       {% endif %}
+
+  test:
+    name: "Test wheel for manylinux {{ manylinux_version }} on {{ '${{ matrix.distribution }}' }} {{ '${{ matrix.version }}' }}"
+    needs:
+      - build
+    runs-on: ubuntu-latest
+    env:
+      # archery uses these environment variables
+      ARCH: amd64
+      PYTHON: "{{ python_version }}"
+    timeout-minutes: 10
+    strategy:
+      fail-fast: false
+      matrix:
+        include:
+          - distribution: conda
+            version: latest
+          - distribution: almalinux
+            version: "8"
+          - distribution: ubuntu
+            version: "18.04"
+          - distribution: ubuntu
+            version: "20.04"
+          - distribution: ubuntu
+            version: "22.04"

Review Comment:
   OK. I'll reduce test patterns and put `verify-release-candidate.sh` based tests to existing jobs instead of creating new jobs.



##########
dev/tasks/python-wheels/github.osx.amd64.yml:
##########
@@ -115,3 +120,52 @@ jobs:
 
       {{ macros.github_upload_releases("arrow/python/repaired_wheels/*.whl")|indent }}
       {{ macros.github_upload_gemfury("arrow/python/repaired_wheels/*.whl")|indent }}
+
+  test:
+    {% raw %}
+    name: "Test wheel for macOS on ${{ matrix.runs-on }} (USE_CONDA=${{ matrix.use-conda }})"
+    {% endraw %}
+    needs:
+      - build
+    {% raw %}
+    runs-on: ${{ matrix.runs-on }}
+    {% endraw %}
+    timeout-minutes: 10
+    strategy:
+      fail-fast: false
+      matrix:
+        runs-on:
+          - macos-11
+          - macos-12
+        use-conda:
+          - "0"
+          - "1"

Review Comment:
   OK. I'll remove conda patterns from our wheel verification nightly jobs too.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org