You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@dubbo.apache.org by GitBox <gi...@apache.org> on 2020/11/03 16:27:59 UTC
[GitHub] [dubbo-getty] cvictory opened a new pull request #49: support sync write package
cvictory opened a new pull request #49:
URL: https://github.com/apache/dubbo-getty/pull/49
Originally sending package is in async way when it is no timeout param.
Now we support one param to turn off sending package in async way but in sync way.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dubbo-getty] cvictory commented on pull request #49: [impl] support sync write package
Posted by GitBox <gi...@apache.org>.
cvictory commented on pull request #49:
URL: https://github.com/apache/dubbo-getty/pull/49#issuecomment-721471660
I want to reduce some goroutine because there are so much connections in alibaba.
I want to remove the write goroutine and keep the read goroutine.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-getty] AlexStocks commented on pull request #49: [impl] support sync write package
Posted by GitBox <gi...@apache.org>.
AlexStocks commented on pull request #49:
URL: https://github.com/apache/dubbo-getty/pull/49#issuecomment-721660817
IMO, this pr should be closed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-getty] codecov-io edited a comment on pull request #49: [impl] support sync write package
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #49:
URL: https://github.com/apache/dubbo-getty/pull/49#issuecomment-721478238
# [Codecov](https://codecov.io/gh/apache/dubbo-getty/pull/49?src=pr&el=h1) Report
> Merging [#49](https://codecov.io/gh/apache/dubbo-getty/pull/49?src=pr&el=desc) into [master](https://codecov.io/gh/apache/dubbo-getty/commit/84c3a0720f450da8dc1c5e1dafae02a5f5abb80a?el=desc) will **increase** coverage by `0.17%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/dubbo-getty/pull/49?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #49 +/- ##
==========================================
+ Coverage 66.07% 66.24% +0.17%
==========================================
Files 8 8
Lines 1350 1357 +7
==========================================
+ Hits 892 899 +7
Misses 365 365
Partials 93 93
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-getty/pull/49?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [client.go](https://codecov.io/gh/apache/dubbo-getty/pull/49/diff?src=pr&el=tree#diff-Y2xpZW50Lmdv) | `67.85% <100.00%> (+0.14%)` | :arrow_up: |
| [options.go](https://codecov.io/gh/apache/dubbo-getty/pull/49/diff?src=pr&el=tree#diff-b3B0aW9ucy5nbw==) | `93.75% <100.00%> (+0.89%)` | :arrow_up: |
| [server.go](https://codecov.io/gh/apache/dubbo-getty/pull/49/diff?src=pr&el=tree#diff-c2VydmVyLmdv) | `65.86% <100.00%> (+0.13%)` | :arrow_up: |
| [session.go](https://codecov.io/gh/apache/dubbo-getty/pull/49/diff?src=pr&el=tree#diff-c2Vzc2lvbi5nbw==) | `65.22% <100.00%> (+0.06%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-getty/pull/49?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-getty/pull/49?src=pr&el=footer). Last update [84c3a07...6543e30](https://codecov.io/gh/apache/dubbo-getty/pull/49?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-getty] wongoo commented on pull request #49: [impl] support sync write package
Posted by GitBox <gi...@apache.org>.
wongoo commented on pull request #49:
URL: https://github.com/apache/dubbo-getty/pull/49#issuecomment-721445823
do u want to sync write package only, or sync request/response? what's the scenario?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dubbo-getty] codecov-io commented on pull request #49: [impl] support sync write package
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #49:
URL: https://github.com/apache/dubbo-getty/pull/49#issuecomment-721478238
# [Codecov](https://codecov.io/gh/apache/dubbo-getty/pull/49?src=pr&el=h1) Report
> Merging [#49](https://codecov.io/gh/apache/dubbo-getty/pull/49?src=pr&el=desc) into [master](https://codecov.io/gh/apache/dubbo-getty/commit/84c3a0720f450da8dc1c5e1dafae02a5f5abb80a?el=desc) will **increase** coverage by `0.17%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/dubbo-getty/pull/49?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #49 +/- ##
==========================================
+ Coverage 66.07% 66.24% +0.17%
==========================================
Files 8 8
Lines 1350 1357 +7
==========================================
+ Hits 892 899 +7
Misses 365 365
Partials 93 93
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-getty/pull/49?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [client.go](https://codecov.io/gh/apache/dubbo-getty/pull/49/diff?src=pr&el=tree#diff-Y2xpZW50Lmdv) | `67.85% <100.00%> (+0.14%)` | :arrow_up: |
| [options.go](https://codecov.io/gh/apache/dubbo-getty/pull/49/diff?src=pr&el=tree#diff-b3B0aW9ucy5nbw==) | `93.75% <100.00%> (+0.89%)` | :arrow_up: |
| [server.go](https://codecov.io/gh/apache/dubbo-getty/pull/49/diff?src=pr&el=tree#diff-c2VydmVyLmdv) | `65.86% <100.00%> (+0.13%)` | :arrow_up: |
| [session.go](https://codecov.io/gh/apache/dubbo-getty/pull/49/diff?src=pr&el=tree#diff-c2Vzc2lvbi5nbw==) | `65.22% <100.00%> (+0.06%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-getty/pull/49?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-getty/pull/49?src=pr&el=footer). Last update [84c3a07...6543e30](https://codecov.io/gh/apache/dubbo-getty/pull/49?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-getty] AlexStocks closed pull request #49: [impl] support sync write package
Posted by GitBox <gi...@apache.org>.
AlexStocks closed pull request #49:
URL: https://github.com/apache/dubbo-getty/pull/49
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org